This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Improve block-selection strategy#10727
Closed
Wizdave97 wants to merge 7 commits intoparitytech:masterfrom
Closed
Conversation
acatangiu
reviewed
Jan 25, 2022
client/beefy/src/worker.rs
Outdated
| C::Api: BeefyApi<B>, | ||
| C::Api: BeefyApi<B, NumberFor<B>>, | ||
| { | ||
| /// Return `true`, if we should vote on block `number` |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Return `true`, if we should vote on block `number` | |
| /// Return `true`, if we should vote on block with `header` |
client/beefy/src/worker.rs
Outdated
| let session_start = if let Some(session_boundary) = session_boundary { | ||
| session_boundary | ||
| } else { | ||
| debug!(target: "beefy", "🥩 Could not retrieve session boundary- won't vote for: {:?}", number); |
Contributor
There was a problem hiding this comment.
I think at least warning here:
Suggested change
| debug!(target: "beefy", "🥩 Could not retrieve session boundary- won't vote for: {:?}", number); | |
| warn!(target: "beefy", "🥩 Could not retrieve session boundary - won't vote for: {:?}", number); |
| fn should_vote_on(&self, header: &B::Header) -> bool { | ||
| let number = *header.number(); | ||
| let at = BlockId::hash(header.hash()); | ||
| let session_boundary = self.client.runtime_api().get_session_boundary(&at).ok(); |
Contributor
There was a problem hiding this comment.
We might want to open an enhancement issue to cache session boundary in the worker and not have to call runtime api for every block here.
Contributor
Author
There was a problem hiding this comment.
I'll keep that in mind.
client/beefy/src/worker.rs
Outdated
Comment on lines
+473
to
+474
| // if the session_start as a mandatory block does not have a beefy justification yet, we vote on | ||
| // it |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| // if the session_start as a mandatory block does not have a beefy justification yet, we vote on | |
| // it | |
| // if the session_start as a mandatory block does not have a beefy justification yet, | |
| // we vote on it |
Comment on lines
-129
to
-130
| /// Minimal delta between blocks, BEEFY should vote for | ||
| pub min_block_delta: u32, |
Contributor
There was a problem hiding this comment.
Let's not remove this. You can still use it on top of your changes as described in beefy.md #L224.
acatangiu
added
A0-please_review
… david/beefy-round-selection
…bstrate into david/beefy-round-selection
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
Contributor
|
Bump |
stale
bot
removed
the
A5-stale
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
Contributor
|
Alternative PR #10882 merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes paritytech/grandpa-bridge-gadget#16
Round selection formula updated to match
as outlined in https://github.com/paritytech/grandpa-bridge-gadget/blob/td-docs/docs/beefy.md#round-selection
Session boundary API that is used here is already implemented in #10669