This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Moving NposSolution to frame#11031
Merged
paritytech-processbot[bot] merged 19 commits intoparitytech:masterfrom Mar 16, 2022
georgesdib:support-to-frame
Merged
Moving NposSolution to frame#11031paritytech-processbot[bot] merged 19 commits intoparitytech:masterfrom georgesdib:support-to-frame
NposSolution to frame#11031paritytech-processbot[bot] merged 19 commits intoparitytech:masterfrom
georgesdib:support-to-frame
Conversation
to `frame-election-provider-support` First stab at it, will need to amend some more stuff
renaming, and re exporting macro.
…eorgesdib/substrate into election-solution-bounded-move
This was referenced Mar 14, 2022
kianenigma
reviewed
Mar 15, 2022
frame/election-provider-support/solution-type/src/single_page.rs
Outdated
Show resolved
Hide resolved
frame/election-provider-support/solution-type/src/single_page.rs
Outdated
Show resolved
Hide resolved
Implementing _fpes better
Incorporate Kian's feedback for moving NPoSSolution to frame
kianenigma
reviewed
Mar 16, 2022
kianenigma
reviewed
Mar 16, 2022
kianenigma
reviewed
Mar 16, 2022
kianenigma
reviewed
Mar 16, 2022
kianenigma
approved these changes
Mar 16, 2022
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Needs to revise some verbose imports, otherwise looks good to me.
kianenigma
added
A0-please_review
kianenigma
added
C1-low
emostov
approved these changes
Mar 16, 2022
Contributor
|
bot merge |
Contributor
|
/tip small |
|
Please fix the following problems before calling the tip bot again:
|
Member
|
/tip small |
1 similar comment
Contributor
|
/tip small |
|
A small tip was successfully submitted for georgesdib (131dPecTmpTC1p1ofemufqFBJo9vNbV7dkgN7vWwKnaSMkC4 on polkadot). |
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Move `sp-npos-elections-solution-type` to `frame-election-provider-support` First stab at it, will need to amend some more stuff * Fixing tests * Fixing tests * Fixing cargo.toml for std configuration * fmt * Committing suggested changes renaming, and re exporting macro. * Removing unneeded imports * Move `NposSolution` to frame * Removing `npos_election` dependencies Implementing _fpes better * some feedback for moving NPoSSolution to frame * fmt * more formatting * Fixed some imports and fmt * Fixing docs Co-authored-by: kianenigma <kian@parity.io>
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Move `sp-npos-elections-solution-type` to `frame-election-provider-support` First stab at it, will need to amend some more stuff * Fixing tests * Fixing tests * Fixing cargo.toml for std configuration * fmt * Committing suggested changes renaming, and re exporting macro. * Removing unneeded imports * Move `NposSolution` to frame * Removing `npos_election` dependencies Implementing _fpes better * some feedback for moving NPoSSolution to frame * fmt * more formatting * Fixed some imports and fmt * Fixing docs Co-authored-by: kianenigma <kian@parity.io>
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Move `sp-npos-elections-solution-type` to `frame-election-provider-support` First stab at it, will need to amend some more stuff * Fixing tests * Fixing tests * Fixing cargo.toml for std configuration * fmt * Committing suggested changes renaming, and re exporting macro. * Removing unneeded imports * Move `NposSolution` to frame * Removing `npos_election` dependencies Implementing _fpes better * some feedback for moving NPoSSolution to frame * fmt * more formatting * Fixed some imports and fmt * Fixing docs Co-authored-by: kianenigma <kian@parity.io>
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* Move `sp-npos-elections-solution-type` to `frame-election-provider-support` First stab at it, will need to amend some more stuff * Fixing tests * Fixing tests * Fixing cargo.toml for std configuration * fmt * Committing suggested changes renaming, and re exporting macro. * Removing unneeded imports * Move `NposSolution` to frame * Removing `npos_election` dependencies Implementing _fpes better * some feedback for moving NPoSSolution to frame * fmt * more formatting * Fixed some imports and fmt * Fixing docs Co-authored-by: kianenigma <kian@parity.io>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Move `sp-npos-elections-solution-type` to `frame-election-provider-support` First stab at it, will need to amend some more stuff * Fixing tests * Fixing tests * Fixing cargo.toml for std configuration * fmt * Committing suggested changes renaming, and re exporting macro. * Removing unneeded imports * Move `NposSolution` to frame * Removing `npos_election` dependencies Implementing _fpes better * some feedback for moving NPoSSolution to frame * fmt * more formatting * Fixed some imports and fmt * Fixing docs Co-authored-by: kianenigma <kian@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #11016
Moving
NposSolutiontoframe-election-provider-supportPolkadot companion: paritytech/polkadot#5112
skip check-dependent-cumulus
Polkadot address: 131dPecTmpTC1p1ofemufqFBJo9vNbV7dkgN7vWwKnaSMkC4
@kianenigma