This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Enforce MaxEncodedLen impl for NposSolution#11103
Merged
paritytech-processbot[bot] merged 5 commits intoparitytech:masterfrom Mar 31, 2022
georgesdib:solution_type_too_big_copy
Merged
Enforce MaxEncodedLen impl for NposSolution#11103paritytech-processbot[bot] merged 5 commits intoparitytech:masterfrom georgesdib:solution_type_too_big_copy
MaxEncodedLen impl for NposSolution#11103paritytech-processbot[bot] merged 5 commits intoparitytech:masterfrom
georgesdib:solution_type_too_big_copy
Conversation
kianenigma
added
A0-please_review
kianenigma
reviewed
Mar 25, 2022
frame/election-provider-support/solution-type/src/single_page.rs
Outdated
Show resolved
Hide resolved
kianenigma
reviewed
Mar 25, 2022
frame/election-provider-support/solution-type/src/single_page.rs
Outdated
Show resolved
Hide resolved
no need to interate to calculate len
kianenigma
approved these changes
Mar 29, 2022
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
LGTM modulo #11103 (comment)
Contributor
|
/tip small |
|
A small tip was successfully submitted for georgesdib (131dPecTmpTC1p1ofemufqFBJo9vNbV7dkgN7vWwKnaSMkC4 on polkadot). |
Contributor
|
bot merge |
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* Fail if `MaxVoters` too small * Fixing benchmarking test, better naming of error * reverting accidental change * use fully qualified syntax no need to interate to calculate len * Fail directly if too many voters
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Fail if `MaxVoters` too small * Fixing benchmarking test, better naming of error * reverting accidental change * use fully qualified syntax no need to interate to calculate len * Fail directly if too many voters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11092
when constructing
NposSolutionviafrom_assignment, check that the number of voters is less than the boundMaxVotersprovided for the implementation ofMaxEncodedLen.@kianenigma
Polkadot address: 131dPecTmpTC1p1ofemufqFBJo9vNbV7dkgN7vWwKnaSMkC4