Change weight template outputs to (x * constants::WEIGH_PER_NANOS)

[hzy1919]

Change the weight template currently outputs from (x as Weight) to (x * constants::WEIGHT_PER_NANOS) which is semantically more clear. Related #11215 .

polkadot address: 15wPGN5vysDW1HYWfZRjQQhv2ktpfLMMuiJNMRKcodwPfM14

[cla-bot-2021]

User @hzy1919, please sign the CLA here.

[ggwpez]

Thanks @hzy1919!
Looks like a format cargo +nightly fmt is needed. There is also a conflict in one of the files, so please merge latest master into your branch and push again.

[ggwpez]

Lets see if the benchbot works here.

[ggwpez]

/bench runtime pallet pallet_balances

[parity-benchapp]

Error running benchmark: change-weight-template-output

stdout

From https://github.com/paritytech/substrate * branch master -> FETCH_HEAD 62fa7d2..0a7e5ea master -> origin/master

[hzy1919]

Thanks @hzy1919! Looks like a format cargo +nightly fmt is needed. There is also a conflict in one of the files, so please merge latest master into your branch and push again.

ok, I will handle it .

[ggwpez]

I will push the weights of a single pallet, to see that it all works. Then we should be good.
Generating the weights takes a while though…

[hzy1919]

hi @ggwpez ，the CI workflows seems failed a few days ago, I am not sure how to solve it , Can you provide some help?

[ggwpez]

The polkadot/cumulus error is unrelated i think. You can try to merge master into your branch and then push (not force push).

[ggwpez]

I think we are nearly done here. Great work so far @hzy1919!

[ggwpez]

I will push some weights again.

[shawntabrizi]

I'm sorry, but end of the day, I don't think I really want this.

I don't see the advantage here. We are strictly adding more complexity and characters to each file.

Also making assumptions which may not always be true, for example that there are no sub-nanosecond weights.

What is more simple than a raw number?

[ggwpez]

As @shawntabrizi reminded me; We will have new weights soon #10918 so it probably makes not much sense now.
Sorry @hzy1919 that we cannot merge it in the end. I think your effort is worth a tip. Maybe someone tips you if you put your address in the MR description like explained here: https://github.com/paritytech/substrate-tip-bot#pull-request-body

[shawntabrizi]

@hzy1919 if you still want a tip for the work you did, please include your polkadot address.

[hzy1919]

Well,it doesn't matter. I'm glad to see a better solution for it . @ggwpez @shawntabrizi Thanks for your patient help ! And i hope i can make more contributions later. 😄

[shawntabrizi]

/tip small

[substrate-tip-bot]

@shawntabrizi A small tip was successfully submitted for hzy1919 (15wPGN5vysDW1HYWfZRjQQhv2ktpfLMMuiJNMRKcodwPfM14 on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips