This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
gavofyork
reviewed
Nov 17, 2018
core/client/db/src/light.rs
Outdated
| transaction.put(columns::HEADER, &lookup_key, &header.encode()); | ||
| transaction.put(columns::HASH_LOOKUP, hash.as_ref(), &lookup_key); | ||
|
|
||
| if number == Zero::zero() { |
Member
There was a problem hiding this comment.
number.is_zero() should be fine (and possibly faster)
gavofyork
approved these changes
Nov 17, 2018
svyatonik
added
A0-please_review
Member
|
There's no need to rebuild the runtime as nothing there was changed. I would generally avoid doing so as it just goes into the PR and creates unnecessary merge conflicts. |
gavofyork
added
A7-looksgoodcantmerge
and removed
A0-please_review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been a while since I last started light client && there are now 2 issues:
Client::new, before network has been started => there were no peers to ask for the state;GENESIS_HASHmeta => updatedread_metafails when light client with non-empty db is started.cc @amaurymartiny