Add experimental support for QUIC by kpp · Pull Request #11514 · paritytech/substrate

kpp · 2022-05-24T12:00:56Z

This is a follow-up of #6366

From the point of view of Substrate:

We now open a UDP socket only if --experimental-quic CLI option is set to true (with default value = false).
This UDP socket is used both to accept incoming QUIC connections but also to establish connections to the respective UDP socket of other nodes. In other words, all communications go through this single socket.
At the moment, since support is experimental, we refuse all incoming QUIC connections by default. One can listen on incoming QUIC connections by passing --listen-addr /ip4/0.0.0.0/udp/30333/quic-v1. Note that multiaddr should listen on quic-v1 not on quic, otherwise the listening will fail.
There is a small caveat at the moment: if you spawn two nodes on the same machine the same UDP port, one of them will fail with "Address already in use". Contrary to TCP/IP, the consequence is that the node which failed to open the UDP port will also be unable to dial the QUIC addresses of other nodes. This is pretty annoying, and I'd be in favour of automatically trying multiple ports if the default one fails to open, but this needs to be brainstormed because of the interaction with --listen-addr.

Before we can consider merging, we need to:

Review and merge the libp2p changes transports/quic: Add implementation based on quinn-proto libp2p/rust-libp2p#2289.
Merge upgrade libp2p to 0.50.0 #12734.
Modify the bandwidth measurement system of libp2p?

So far I managed to connect two nodes through QUIC:

cargo r --bin node-template -- --no-mdns --experimental-quic --listen-addr /ip6/::1/tcp/8081 /ip6/::1/udp/8081/quic-v1 --alice --tmp
cargo r --bin node-template -- --no-mdns --experimental-quic --listen-addr /ip4/0.0.0.0/udp/8080/quic-v1 --bootnodes /ip6/::1/udp/8081/quic-v1/p2p/12D3KooWRRNUr42JBC79TuiWSg3BnAcsNwjT6zasJsCrcB5bgaxK --bob --tmp

client/cli/src/params/network_params.rs

Co-authored-by: Max Wase <max.vvase@gmail.com>

cla-bot-2021 · 2022-05-26T12:46:16Z

User @maxwase, please sign the CLA here.

stale · 2022-06-25T19:24:34Z

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

kpp · 2022-06-25T20:18:59Z

I am working on this.

stale · 2022-08-31T01:35:59Z

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

kpp · 2022-08-31T11:59:05Z

I am working on this. This is a very important issue.

crystalin · 2022-08-31T12:31:48Z

@kpp can you give us an update? I agree this is important specially considering the issues with networking/parachains at the moment

kpp · 2022-08-31T19:10:02Z

So we got 2 working implementations: libp2p/rust-libp2p#2289 and libp2p/rust-libp2p#2801. Both of them are compatible with the go implementation but none of them are merged.

stale · 2022-09-30T19:48:08Z

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

kpp · 2022-10-01T09:33:31Z

I am working on this issue

dmitry-markin

LGTM! 👍

client/network/src/transport.rs

dmitry-markin · 2023-02-03T12:41:49Z

client/network/src/transport.rs

-		.timeout(Duration::from_secs(20))
+		.timeout(Duration::from_secs(20));
+
+	let quic_transport = if enable_quic {


IMO the either way is OK.

stale · 2023-03-16T01:21:20Z

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

client/network/src/transport.rs

stale · 2023-04-15T04:17:16Z

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

Co-authored-by: Anton <anton.kalyaev@gmail.com>

stale · 2023-05-25T17:10:51Z

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

crystalin · 2023-06-09T05:51:45Z

:(

stale · 2023-07-14T18:39:13Z

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2023-08-21T22:03:45Z

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

kpp added 2 commits May 24, 2022 14:57

Patch libp2p

b448b6d

Build QUIC transport

bb7abd9

github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label May 24, 2022

kpp added 2 commits May 24, 2022 15:32

Pass quic_port through cli args

450d260

Build quic transport from cli args

f052690

kpp mentioned this pull request May 24, 2022

Tracking issue for QUIC support paritytech/polkadot-sdk#536

Open

10 tasks

maxwase reviewed May 24, 2022

View reviewed changes

client/cli/src/params/network_params.rs Outdated Show resolved Hide resolved

Review fixes: ipv6 :: addr

4d61feb

Co-authored-by: Max Wase <max.vvase@gmail.com>

kpp added B0-silent Changes should not be mentioned in any release notes D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 26, 2022

stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jun 25, 2022

stale bot closed this Jul 9, 2022

kpp removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 12, 2022

kpp reopened this Jul 12, 2022

kpp added 3 commits July 12, 2022 15:48

Merge branch 'master' into kpp-quic

5504f4c

Upgrade libp2p to 0.47.0

f661801

Merge branch 'master' into kpp-quic

0b56dc1

stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Aug 31, 2022

kpp removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Aug 31, 2022

stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Sep 30, 2022

kpp removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Oct 1, 2022

kpp added the C1-low PR touches the given topic and has a low impact on builders. label Feb 1, 2023

dmitry-markin approved these changes Feb 3, 2023

View reviewed changes

the-right-joyce added B1-note_worthy Changes should be noted in the release notes T0-node This PR/Issue is related to the topic “node”. and removed B5-clientnoteworthy labels Feb 13, 2023

stale bot added the A3-stale label Mar 16, 2023

melekes reviewed Mar 16, 2023

View reviewed changes

client/network/src/transport.rs Outdated Show resolved Hide resolved

client/network/src/transport.rs Outdated Show resolved Hide resolved

stale bot removed A3-stale labels Mar 16, 2023

stale bot added the A3-stale label Apr 15, 2023

dmitry-markin removed the A3-stale label Apr 21, 2023

Update client/network/src/transport.rs

fcc4b51

Co-authored-by: Anton <anton.kalyaev@gmail.com>

kamilsa mentioned this pull request May 3, 2023

Libp2p improvements qdrvm/kagome#1589

Open

1 task

stale bot added the A3-stale label May 25, 2023

stale bot closed this Jun 9, 2023

Merge branch 'master' into kpp-quic

62ff75e

kpp reopened this Jun 14, 2023

stale bot removed the A3-stale label Jun 14, 2023

stale bot added the A3-stale label Jul 14, 2023

dmitry-markin removed the A3-stale label Jul 20, 2023

stale bot added the A3-stale label Aug 21, 2023

dmitry-markin removed the A3-stale label Aug 23, 2023

Conversation

kpp commented May 24, 2022 • edited by dmitry-markin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cla-bot-2021 bot commented May 26, 2022

Uh oh!

stale bot commented Jun 25, 2022

Uh oh!

kpp commented Jun 25, 2022

Uh oh!

stale bot commented Aug 31, 2022

Uh oh!

kpp commented Aug 31, 2022

Uh oh!

crystalin commented Aug 31, 2022

Uh oh!

kpp commented Aug 31, 2022

Uh oh!

stale bot commented Sep 30, 2022

Uh oh!

kpp commented Oct 1, 2022

Uh oh!

dmitry-markin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dmitry-markin Feb 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stale bot commented Mar 16, 2023

Uh oh!

Uh oh!

Uh oh!

stale bot commented Apr 15, 2023

Uh oh!

stale bot commented May 25, 2023

Uh oh!

crystalin commented Jun 9, 2023

Uh oh!

stale bot commented Jul 14, 2023

Uh oh!

stale bot commented Aug 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kpp commented May 24, 2022 •

edited by dmitry-markin

Loading

dmitry-markin Feb 3, 2023 •

edited

Loading