This repository was archived by the owner on Nov 15, 2023. It is now read-only.
[Uniques V2] Auto-incremental CollectionId#12166
Closed
jsidorenko wants to merge 1 commit intojs/uniques-v2-main-branchfrom
Closed
[Uniques V2] Auto-incremental CollectionId#12166jsidorenko wants to merge 1 commit intojs/uniques-v2-main-branchfrom
jsidorenko wants to merge 1 commit intojs/uniques-v2-main-branchfrom
Conversation
jsidorenko
added
B7-runtimenoteworthy
C1-low
jsidorenko
added
the
D3-trivial 🧸
This was referenced Sep 2, 2022
Contributor
Author
|
Closing in favor of #12057 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new field called
ref_idto Uniques Collections. Since we can't make the CollectionId field itself auto-incremental (as discussed here, as a possible solution we can have this internal field, that will be auto-incremented in every collection creation.This solves the problem when one collection was deleted and then another with the same CollectionId was created. That new
ref_idfield would allow distinguishing between those collections.