This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
arkpar
added
A0-please_review
bkchr
approved these changes
Sep 15, 2022
cheme
approved these changes
Sep 16, 2022
Contributor
cheme
left a comment
cheme
left a comment
There was a problem hiding this comment.
Method skip_execution_checks could be do_execution_checks since we always negate it.
But at the same time skip_execution_checks sounds like a better semantic (this being an exception). So may not be a good change
Member
Author
|
bot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12268