This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
Contributor
|
The change looks fine, I am just wondering about two scenarios:
Arguable neither of these two problem were introduced in this PR. However if acknowledge these problem, we should create tickets for them, now? //cc @rphmeier |
Member
Author
|
Originally tie syncing code was supposed to correctly download blocks from all forks. For that it keeps track of most recent common block with every peers and downloads from that point. This appears to broken now indeed as indicated by the tests. I've pushed another commit that fixes it. As for detecting malicious behaviour the block queue keeps track of |
gavofyork
approved these changes
Dec 10, 2018
Closed
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
* Fixed common block tracking when syncing * Fixed fork resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sync module needs to track the best queued block, it does not care so much about the best imported. Before the block queue was introduced these were effectively the same. With the block queue this small change is required.