Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Update UI tests for Rust 1.64#12440

Merged
bkchr merged 3 commits intomasterfrom
vi-rust-1.64
Oct 10, 2022
Merged

Update UI tests for Rust 1.64#12440
bkchr merged 3 commits intomasterfrom
vi-rust-1.64

Conversation

@rcny
Copy link
Contributor

@rcny rcny commented Oct 6, 2022

This PR updates UI tests to make stable 1.64 rustc happy. The tests were updated via the machinery using the /.maintain/update-rust-stable.sh script.

@rcny rcny added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Oct 6, 2022
@rcny rcny requested review from a team and bkchr October 6, 2022 16:58
@rcny rcny self-assigned this Oct 6, 2022
@rcny rcny added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Oct 6, 2022
@ggwpez
Copy link
Member

ggwpez commented Oct 6, 2022 •
edited
Loading

Looks like we finally need to fix this one since the CI is red:

error: associated function `project_ref` is never used
  --> client/telemetry/src/transport.rs:80:1
   |
80 | #[pin_project::pin_project]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D dead-code` implied by `-D warnings`

PS: Already done in #12426

@rcny rcny mentioned this pull request Oct 7, 2022
Merged
@rcny
Copy link
Contributor Author

rcny commented Oct 10, 2022 •
edited
Loading

Needs a force merge.

@bkchr bkchr merged commit 9672c36 into master Oct 10, 2022
@bkchr bkchr deleted the vi-rust-1.64 branch October 10, 2022 18:04
@aurexav aurexav mentioned this pull request Jan 10, 2023
Closed
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@rcny @ark0f
Update UI tests for Rust 1.64 (paritytech#12440)
c6ed021 
* Update UI tests for Rust 1.64

* Test with the staging image

* Switch back to production
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@bkchr bkchr bkchr approved these changes

@tonyalaribe tonyalaribe tonyalaribe approved these changes

@ggwpez ggwpez ggwpez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rcny rcny

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rcny @ggwpez @bkchr @tonyalaribe