This repository was archived by the owner on Nov 15, 2023. It is now read-only.
cumulus v0.9.30 cherry pick bench fix from master#12543
Closed
muharem wants to merge 8 commits intocumulus-v0.9.30from
Closed
cumulus v0.9.30 cherry pick bench fix from master#12543muharem wants to merge 8 commits intocumulus-v0.9.30from
muharem wants to merge 8 commits intocumulus-v0.9.30from
Conversation
…ive (#12482) * Force base weights to be the minimum only when the intercept is negative; emit minimum execution times * Add an `assert` making sure the intercept is zero when it's supposed to be zero * Fix template Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * ".git/.scripts/bench-bot.sh" pallet dev pallet_assets * ".git/.scripts/bench-bot.sh" pallet dev pallet_uniques Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: command-bot <>
muharem
added
A0-please_review
ggwpez
approved these changes
Oct 21, 2022
Member
ggwpez
left a comment
ggwpez
left a comment
There was a problem hiding this comment.
The CI shows a merge conflict but GitHub does not…
EgorPopelyaev
added
the
C1-low
Contributor
|
Let's not modify the |
muharem
changed the title
Contributor
Author
done |
Contributor
|
After a bit of convincing, our CI turned green on a few more points: |
Contributor
passed locally. |
chevdor
approved these changes
Oct 24, 2022
Contributor
|
This PR #12556 should fix the clippy issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick the benchmarks fix from master
Fix PR #12482
substrate companion branch: cumulus-v0.9.30
polkadot companion branch: release-v0.9.30
cumulus companion branch: polkadot-v0.9.30