Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Make Assets Pallet's Privileged Roles Option#12579

Closed
dharjeezy wants to merge 27 commits intoparitytech:masterfrom
dharjeezy:dharjeezy/pallet-assets-details-option
Closed

Make Assets Pallet's Privileged Roles Option#12579
dharjeezy wants to merge 27 commits intoparitytech:masterfrom
dharjeezy:dharjeezy/pallet-assets-details-option

Conversation

@dharjeezy
Copy link
Contributor

@dharjeezy dharjeezy commented Oct 28, 2022 •
edited
Loading

Include Option for struct AssetDetails
Cumulus companion paritytech/cumulus#1912
closes paritytech/polkadot-sdk#91

Polkadot address: 12ZNas89oEagaxLVNbpqmvfMxdrGrqN7gJKSpwthTUPZsrku

@dharjeezy
Copy link
Contributor Author

dharjeezy commented Oct 28, 2022

@joepetrowski

@joepetrowski joepetrowski added A3-in_progress Pull request is in progress. No review needed at this stage. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Oct 28, 2022
@joepetrowski
Copy link
Contributor

joepetrowski commented Oct 28, 2022

Thanks! Will need a migration and companion in Cumulus for existing assets.

@dharjeezy
Copy link
Contributor Author

dharjeezy commented Oct 29, 2022

Thanks! Will need a migration and companion in Cumulus for existing assets.

Oh..Alright

@gilescope gilescope requested a review from jsidorenko November 9, 2022 18:29
jsidorenko
jsidorenko reviewed Nov 17, 2022
View reviewed changes
jsidorenko
jsidorenko reviewed Nov 17, 2022
View reviewed changes
@dharjeezy
lock
f9799f4
@dharjeezy
Merge branch 'master' of https://github.com/dharjeezy/substrate into …
9466b5d 
…dharjeezy/pallet-assets-details-option

� Conflicts:
�	frame/assets/src/functions.rs
�	frame/assets/src/lib.rs
�	frame/assets/src/migration.rs
@dharjeezy
fix merge conflict
2eb1537 
migration to v2
@dharjeezy dharjeezy marked this pull request as draft November 24, 2022 01:11
@dharjeezy dharjeezy mentioned this pull request Nov 24, 2022
Open
@dharjeezy dharjeezy marked this pull request as ready for review November 26, 2022 10:58
@dharjeezy dharjeezy requested review from joepetrowski and jsidorenko and removed request for joepetrowski and jsidorenko November 26, 2022 10:58
jsidorenko
jsidorenko reviewed Dec 14, 2022
View reviewed changes
@paritytech-processbot
Copy link

paritytech-processbot bot commented Mar 22, 2023

Error: Response error (status 404 Not Found): 

{"documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user","message":"User does not exist or is not a member of the organization"}

@tonyalaribe
Copy link
Contributor

tonyalaribe commented Mar 22, 2023

bot rebase

@paritytech-processbot
Copy link

paritytech-processbot bot commented Mar 22, 2023

Rebased

dharjeezy added 3 commits April 2, 2023 08:24
@dharjeezy
fix migration
bdbbcdd
@dharjeezy
Merge remote-tracking branch 'origin/dharjeezy/pallet-assets-details-…
a785a08 
…option' into dharjeezy/pallet-assets-details-option

# Conflicts:
#	frame/assets/src/migration.rs
@dharjeezy
fix cargo build issues
e155cda
@dharjeezy
Copy link
Contributor Author

dharjeezy commented Apr 4, 2023

I have fixed the migration @joepetrowski
@jsidorenko you can take a look

@stale
Copy link

stale bot commented May 5, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label May 5, 2023
@jsidorenko
Copy link
Contributor

jsidorenko commented May 5, 2023

bot rebase

@paritytech-processbot
Copy link

paritytech-processbot bot commented May 5, 2023

Rebased

@paritytech-processbot paritytech-processbot bot requested a review from a team May 5, 2023 14:21
jsidorenko and others added 3 commits May 5, 2023 16:29
@jsidorenko @joepetrowski
Update frame/assets/src/migration.rs
f2580be 
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Refactoring
1244d20
Fix benches
aad17d7
@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented May 5, 2023

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2790386

@stale
Copy link

stale bot commented Jun 8, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Jun 8, 2023
@stale
Copy link

stale bot commented Jul 13, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Jul 13, 2023
@stale stale bot closed this Jul 27, 2023
@jsidorenko
Copy link
Contributor

jsidorenko commented Jul 27, 2023

@joepetrowski pls re-open if we still need this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ggwpez ggwpez Awaiting requested review from ggwpez

@jsidorenko jsidorenko Awaiting requested review from jsidorenko

@joepetrowski joepetrowski Awaiting requested review from joepetrowski

Assignees

No one assigned

Labels

A3-in_progress Pull request is in progress. No review needed at this stage. A3-stale B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. T1-runtime This PR/Issue is related to the topic “runtime”.

Projects

Security Audit (PRs) - SRLabs
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Assets Pallet's Privileged Roles Option

6 participants

@dharjeezy @joepetrowski @jsidorenko @tonyalaribe @paritytech-cicd-pr @the-right-joyce