permissionless `bond_extra` in nomination pools by Doordashcon · Pull Request #12608 · paritytech/substrate

Doordashcon · 2022-11-03T09:39:54Z

Resolves #11638

polkadot address: 12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h

polkadot companion: paritytech/polkadot#6753

Doordashcon · 2022-11-09T20:09:37Z

Ideally this action should not be at any cost to pool operators?

Asked this because I had no idea incentives were not offered to pool operators.

kianenigma · 2022-11-15T15:18:24Z

frame/nomination-pools/src/lib.rs

+		// TODO: For when the pool member leaves or is kiked out, clear storage.
+		// Update weight info
+		#[pallet::weight(T::DbWeight::get().reads_writes(1, 1))]
+		pub fn set_claimable_action(origin: OriginFor<T>, action: bool) -> DispatchResult {


Action should be an enum with better names about what each variant mean.

And then impl Default for Action should be whatever it is the current behavior, so that we won't need any migration.

Making it an enum would be preferred because this makes it into a binary state and more actions can be added if needed.

so that we won't need any migration.

I am curious as to why we should avoid making migrations in this case?

When a member unbond should that change action back to default?

I am curious as to why we should avoid making migrations in this case?

If you have a map for user's desired behavior, then you won't need a migration.
If you want to add this as a new filed to the Member, which is arguably the more "neat" way of doing this, then you would need a migration.

For now, the map approach is fine. But if you are down for it, I am down to experiment with the alternative as well.

When a member unbond should that change action back to default?

Can you elaborate on the scenario? I don't think unbond would have anything to do with this. When the member fully unbonds and leaves the system, then their entry in this map should also be removed.

frame/nomination-pools/src/lib.rs

kianenigma · 2022-11-20T14:57:01Z

We discussed this internally and our interim opinion is to not add a new role for this, and not attach it to root either.

If a user allows this, ANYONE should be able to claim their rewards. WDYT @Doordashcon?

(we will soon post this in the polkadot forum as well to get more feedback from the existing pool operators.)

Doordashcon · 2022-11-23T11:33:36Z

(we will soon post this in the polkadot forum as well to get more feedback from the existing pool operators.)

Sounds good @kianenigma i'll wait till it's up on the forum before implementing changes.

Polkadot-Forum · 2022-11-28T20:46:08Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/roles-in-nomination-pools/1169/5

frame/nomination-pools/src/lib.rs

kianenigma

I think we can move forward with this. Needs a few renames and tweaks, but in general is looking good.

rossbulat · 2023-02-21T11:56:08Z

bot fmt

command-bot · 2023-02-21T11:56:13Z

@rossbulat https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2423241 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 16-aecb558a-8df6-43ca-bd19-a38e048ce880 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-02-21T11:57:24Z

@rossbulat Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2423241 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2423241/artifacts/download.

frame/nomination-pools/src/lib.rs

rossbulat · 2023-02-22T05:30:40Z

bot rebase

paritytech-processbot · 2023-02-22T05:30:47Z

Rebased

rossbulat · 2023-02-22T11:18:01Z

bot rebase

paritytech-processbot · 2023-02-22T11:18:08Z

Rebased

rossbulat · 2023-02-22T12:17:01Z

bot merge

* create enum * logic check * add benchmarks * -enum * update * bond extra other * update * update * update * cargo fmt * Permissioned * update * cargo fmt * update * update index * doc update Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> * doc update Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * cargo fmt * bond_extra auto compound * bond_extra_other * Apply suggestions from code review * Fixes from kian * updates docs & test * Update frame/nomination-pools/src/lib.rs * Update frame/nomination-pools/src/lib.rs * Update frame/nomination-pools/src/lib.rs * Update frame/nomination-pools/src/lib.rs * Update frame/nomination-pools/src/lib.rs * Update frame/nomination-pools/src/tests.rs * Update frame/nomination-pools/src/lib.rs * Update frame/nomination-pools/src/tests.rs * Update frame/nomination-pools/src/tests.rs * Update frame/nomination-pools/src/tests.rs * Update frame/nomination-pools/src/tests.rs * Update frame/nomination-pools/src/tests.rs * Update frame/nomination-pools/src/lib.rs * Update frame/nomination-pools/src/tests.rs * fixes + fmt * expand ClaimPermissions + add benchmarks * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nomination_pools * tidy up claim payout benches * fix * + test: claim_payout_other_works * comments, rename to set_claim_permission * fix comment * remove ClaimPermission on leave pool * fix test * ".git/.scripts/commands/fmt/fmt.sh" * + test for ClaimPermissions::remove() * impl can_bond_extra & can_claim_payout --------- Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: kianenigma <kian@parity.io> Co-authored-by: parity-processbot <> Co-authored-by: Ross Bulat <ross@parity.io>

Polkadot-Forum · 2023-03-15T04:20:28Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/discussion-on-global-maximum-commission-for-nomination-pools-on-polkadot/2325/1

* create enum * logic check * add benchmarks * -enum * update * bond extra other * update * update * update * cargo fmt * Permissioned * update * cargo fmt * update * update index * doc update Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> * doc update Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * cargo fmt * bond_extra auto compound * bond_extra_other * Apply suggestions from code review * Fixes from kian * updates docs & test * Update frame/nomination-pools/src/lib.rs * Update frame/nomination-pools/src/lib.rs * Update frame/nomination-pools/src/lib.rs * Update frame/nomination-pools/src/lib.rs * Update frame/nomination-pools/src/lib.rs * Update frame/nomination-pools/src/tests.rs * Update frame/nomination-pools/src/lib.rs * Update frame/nomination-pools/src/tests.rs * Update frame/nomination-pools/src/tests.rs * Update frame/nomination-pools/src/tests.rs * Update frame/nomination-pools/src/tests.rs * Update frame/nomination-pools/src/tests.rs * Update frame/nomination-pools/src/lib.rs * Update frame/nomination-pools/src/tests.rs * fixes + fmt * expand ClaimPermissions + add benchmarks * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nomination_pools * tidy up claim payout benches * fix * + test: claim_payout_other_works * comments, rename to set_claim_permission * fix comment * remove ClaimPermission on leave pool * fix test * ".git/.scripts/commands/fmt/fmt.sh" * + test for ClaimPermissions::remove() * impl can_bond_extra & can_claim_payout --------- Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: kianenigma <kian@parity.io> Co-authored-by: parity-processbot <> Co-authored-by: Ross Bulat <ross@parity.io>

create enum

c5cde02

Doordashcon changed the title ~~Allow pool operators to manage claimable fund~~ Allow pool operators bond_extra Nov 7, 2022

logic check

3ab9cd7

Doordashcon marked this pull request as ready for review November 13, 2022 12:04

add benchmarks

59958d5

kianenigma reviewed Nov 15, 2022

View reviewed changes

doordashcon added 2 commits November 18, 2022 15:01

-enum

9d54b8a

Merge branch 'paritytech:master' into ddc-MCF-T1

8efecfe

kianenigma requested review from Ank4n, gpestana and ruseinov November 19, 2022 15:42

update

f7b0a2d

ruseinov reviewed Nov 20, 2022

View reviewed changes

frame/nomination-pools/src/lib.rs Outdated Show resolved Hide resolved

bond extra other

8931433

kianenigma reviewed Dec 4, 2022

View reviewed changes

frame/nomination-pools/src/lib.rs Outdated Show resolved Hide resolved

kianenigma reviewed Dec 4, 2022

View reviewed changes

frame/nomination-pools/src/lib.rs Outdated Show resolved Hide resolved

kianenigma reviewed Dec 4, 2022

View reviewed changes

frame/nomination-pools/src/lib.rs Outdated Show resolved Hide resolved

kianenigma reviewed Dec 4, 2022

View reviewed changes

frame/nomination-pools/src/lib.rs Outdated Show resolved Hide resolved

kianenigma reviewed Dec 4, 2022

View reviewed changes

frame/nomination-pools/src/lib.rs Outdated Show resolved Hide resolved

kianenigma reviewed Dec 4, 2022

View reviewed changes

frame/nomination-pools/src/lib.rs Outdated Show resolved Hide resolved

kianenigma reviewed Dec 4, 2022

View reviewed changes

kianenigma added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Dec 4, 2022

update

9f83103

Ross Bulat added 4 commits February 21, 2023 14:00

comments, rename to set_claim_permission

4bdf22a

fix comment

2965fd9

remove ClaimPermission on leave pool

7c16c8e

fix test

ef63fdf

".git/.scripts/commands/fmt/fmt.sh"

f8cedba

kianenigma reviewed Feb 21, 2023

View reviewed changes

frame/nomination-pools/src/lib.rs Outdated Show resolved Hide resolved

jakoblell added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Feb 21, 2023

Merge remote-tracking branch 'origin/master' into ddc-MCF-T1

4ac673b

Ross Bulat added 2 commits February 22, 2023 18:06

+ test for ClaimPermissions::remove()

0ea2309

impl can_bond_extra & can_claim_payout

a39573c

Merge remote-tracking branch 'origin/master' into ddc-MCF-T1

f7a6568

paritytech-processbot bot merged commit 473b5d0 into paritytech:master Feb 22, 2023

rossbulat mentioned this pull request Aug 24, 2023

Staking Fuzzer to test nomination pool commission & absent calls paritytech/polkadot-sdk#424

Open

kiltbot mentioned this pull request Apr 3, 2023

[AUTOMATIC] Update Polkadot dependencies from 0.9.38 to 0.9.39 KILTprotocol/kilt-node#495

Closed

librelois mentioned this pull request Apr 6, 2023

Update substrate/polkadot/cumulus from v0.9.38 to v0.9.40 moonbeam-foundation/moonbeam#2200

Closed

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

Conversation

Doordashcon commented Nov 3, 2022 • edited by rossbulat Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Doordashcon commented Nov 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kianenigma Nov 15, 2022

Choose a reason for hiding this comment

Uh oh!

kianenigma Nov 15, 2022

Choose a reason for hiding this comment

Uh oh!

Doordashcon Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Doordashcon Nov 15, 2022

Choose a reason for hiding this comment

Uh oh!

Doordashcon Nov 15, 2022

Choose a reason for hiding this comment

Uh oh!

kianenigma Nov 28, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kianenigma commented Nov 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Doordashcon commented Nov 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Polkadot-Forum commented Nov 28, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kianenigma left a comment

Choose a reason for hiding this comment

Uh oh!

rossbulat commented Feb 21, 2023

Uh oh!

command-bot bot commented Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Feb 21, 2023

Uh oh!

Uh oh!

rossbulat commented Feb 22, 2023

Uh oh!

paritytech-processbot bot commented Feb 22, 2023

Uh oh!

rossbulat commented Feb 22, 2023

Uh oh!

paritytech-processbot bot commented Feb 22, 2023

Uh oh!

rossbulat commented Feb 22, 2023

Uh oh!

Polkadot-Forum commented Mar 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Doordashcon commented Nov 3, 2022 •

edited by rossbulat

Loading

Doordashcon commented Nov 9, 2022 •

edited

Loading

Doordashcon Nov 15, 2022 •

edited

Loading

kianenigma commented Nov 20, 2022 •

edited

Loading

Doordashcon commented Nov 23, 2022 •

edited

Loading

command-bot bot commented Feb 21, 2023 •

edited

Loading