Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

[pallet-assets] add asset_exists(id: AssetId) function#12782

Merged
paritytech-processbot[bot] merged 3 commits intoparitytech:masterfrom
dharjeezy:dharjeezy/asset-exists
Dec 8, 2022
Merged

[pallet-assets] add asset_exists(id: AssetId) function#12782
paritytech-processbot[bot] merged 3 commits intoparitytech:masterfrom
dharjeezy:dharjeezy/asset-exists

Conversation

@dharjeezy
Copy link
Contributor

@dharjeezy dharjeezy commented Nov 26, 2022 •
edited
Loading

Checks if an asset exists via loose coupling(the Inspect trait).

closes #12444

joepetrowski
joepetrowski reviewed Nov 26, 2022
View reviewed changes
@dharjeezy @joepetrowski
Update frame/support/src/traits/tokens/fungibles.rs
8974d8f 
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
@joepetrowski
Copy link
Contributor

joepetrowski commented Dec 6, 2022

I think you should add this to fungible::Inspect too.

@dharjeezy
Copy link
Contributor Author

dharjeezy commented Dec 7, 2022

I think you should add this to fungible::Inspect too.

Alright

@dharjeezy
Copy link
Contributor Author

dharjeezy commented Dec 7, 2022

I think you should add this to fungible::Inspect too.

@joepetrowski in this case, are we going to introduce a new type AssetId: AssetId; since it isn't in the trait initally
?

@joepetrowski
Copy link
Contributor

joepetrowski commented Dec 8, 2022

That is a great point. Seems obvious now, but looking at fungible I don't think it makes sense to add AssetId to it. In that case I'm OK with this PR.

@joepetrowski joepetrowski added A0-please_review Pull request needs code review. B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 8, 2022
@ggwpez
Copy link
Member

ggwpez commented Dec 8, 2022

bot rebase

@paritytech-processbot
Copy link

paritytech-processbot bot commented Dec 8, 2022

Rebased

@ggwpez
Copy link
Member

ggwpez commented Dec 8, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit fae9e36 into paritytech:master Dec 8, 2022
@bernardoaraujor bernardoaraujor mentioned this pull request Dec 8, 2022
Closed
joao-paulo-parity added a commit to joao-paulo-parity/substrate that referenced this pull request Dec 9, 2022
@joao-paulo-parity
wip: reproduce paritytech#12782
f40a6a4
@zjb0807 zjb0807 mentioned this pull request Dec 21, 2022
Merged
@Polkadot-Forum
Copy link

Polkadot-Forum commented Dec 22, 2022

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-36/1529/1

@aurexav aurexav mentioned this pull request Jan 10, 2023
Closed
@librelois librelois mentioned this pull request Jan 23, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Feb 14, 2023
Merged
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
@dharjeezy @joepetrowski @ltfschoen
[pallet-assets] add asset_exists(id: AssetId) function (paritytech#12782
f15b33b 
)

* check if an asset exists via loose coupling

* Update frame/support/src/traits/tokens/fungibles.rs

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: parity-processbot <>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@dharjeezy @joepetrowski @ark0f
[pallet-assets] add asset_exists(id: AssetId) function (paritytech#12782
7190f7e 
)

* check if an asset exists via loose coupling

* Update frame/support/src/traits/tokens/fungibles.rs

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ggwpez ggwpez ggwpez approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[pallet-assets] add asset_exists(id: AssetId) function

4 participants

@dharjeezy @joepetrowski @ggwpez @Polkadot-Forum