This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Trial crates publishing automation#12880
Closed
joao-paulo-parity wants to merge 2 commits intoparitytech:masterfrom
Closed
Trial crates publishing automation#12880joao-paulo-parity wants to merge 2 commits intoparitytech:masterfrom
joao-paulo-parity wants to merge 2 commits intoparitytech:masterfrom
Conversation
joao-paulo-parity
added
A2-insubstantial
Member
|
Why was this closed? I think we often have this problem, or? |
Contributor
Author
|
@ggwpez I found out that stripping dev-dependencies is regardless necessary (rust-lang/cargo#4242 for context), but perhaps the stripping algorithm could be smarter as I mentioned in #12899 (review). |
joao-paulo-parity
force-pushed
the
crates-revert
branch
from
37bb7c7 to
d123900
Compare
joao-paulo-parity
changed the title
joao-paulo-parity
force-pushed
the
crates-revert
branch
from
a51f418 to
726f62f
Compare
joao-paulo-parity
force-pushed
the
crates-revert
branch
from
e3de686 to
15aa49f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The automation shall no longer strip dev-dependencies before publishing, therefore the workaround of using dev-dependencies as optional dependencies (from #12768) will no longer be necessary.