This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Move LockableCurrency trait to fungible::Lockable and deprecate LockableCurrency#12887
Closed
tonyalaribe wants to merge 36 commits intomasterfrom
Closed
Move LockableCurrency trait to fungible::Lockable and deprecate LockableCurrency#12887tonyalaribe wants to merge 36 commits intomasterfrom
tonyalaribe wants to merge 36 commits intomasterfrom
Conversation
…ate into aa/lockable-for-assets
…ate into aa/lockable-for-assets
Co-authored-by: Squirrel <gilescope@gmail.com>
Co-authored-by: Squirrel <gilescope@gmail.com>
github-actions
bot
added
the
A3-in_progress
github-actions
bot
added
A0-please_review
tonyalaribe
changed the title
jsidorenko
reviewed
Dec 12, 2022
| assert_noop, assert_storage_noop, assert_ok, assert_err, | ||
| traits::{ | ||
| LockableCurrency, LockIdentifier, WithdrawReasons, | ||
| fungible, fungible::Lockable, WithdrawReasons, |
Contributor
There was a problem hiding this comment.
What would happen if you don't include fungible::Lockable?
Contributor
Author
There was a problem hiding this comment.
I get this, if fungible::Lockable isn't included:
…le::Lockable can have breaking changes
…trate into aa/lockable-for-assets-2
Contributor
|
How does this work link to paritytech/polkadot-sdk#236? has it been discussed/coordinated? |
melekes
approved these changes
Dec 26, 2022
Contributor
melekes
left a comment
melekes
left a comment
There was a problem hiding this comment.
👍 (code-wise; don't know enough to reason about business logic)
| //! NOTE: If you're looking for `parameter_types`, it has moved in to the top-level module. | ||
|
|
||
| pub mod tokens; | ||
| #[allow(deprecated)] |
Contributor
Author
It's intended to be a step in that direction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Priliminary efforts to introduce a Lockable trait based off LockableCurrency.
This moves us closer to the points in paritytech/polkadot-sdk#327