This repository was archived by the owner on Nov 15, 2023. It is now read-only.
[contracts] Make debug buffer work like a FIFO pipe#12953
Merged
Conversation
agryaznov
added
A0-please_review
xermicus
reviewed
Dec 16, 2022
melekes
approved these changes
Dec 22, 2022
Contributor
melekes
left a comment
melekes
left a comment
There was a problem hiding this comment.
👍 (code-wise; don't know enough to reason about business logic)
agryaznov
commented
Dec 23, 2022
Co-authored-by: Sasha Gryaznov <hi@agryaznov.com>
athei
approved these changes
Dec 27, 2022
athei
added
D9-needsaudit 👮
xermicus
approved these changes
Dec 27, 2022
rossbulat
pushed a commit
that referenced
this pull request
Dec 28, 2022
* make debug buffer work like a FIFO pipe * remove unused Error type * Remove panics * Update frame/contracts/src/exec.rs Co-authored-by: Sasha Gryaznov <hi@agryaznov.com> Co-authored-by: Alexander Theißen <alex.theissen@me.com>
jakoblell
added
D1-audited 👍
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
* make debug buffer work like a FIFO pipe * remove unused Error type * Remove panics * Update frame/contracts/src/exec.rs Co-authored-by: Sasha Gryaznov <hi@agryaznov.com> Co-authored-by: Alexander Theißen <alex.theissen@me.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* make debug buffer work like a FIFO pipe * remove unused Error type * Remove panics * Update frame/contracts/src/exec.rs Co-authored-by: Sasha Gryaznov <hi@agryaznov.com> Co-authored-by: Alexander Theißen <alex.theissen@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12845
Instead of falling on the debug buffer exhaustion, drain it from the beginning by the overflowing message size, effectively making it a FIFO buffer.
This should make the contract outcome the same for an on-chain run (where debug buffer normally disabled, and hence execution can't fail with its exhaustion) and an RPC call (often having it enabled for debugging, hence currently the same contract could fail here while succeed on-chain).