This repository was archived by the owner on Nov 15, 2023. It is now read-only.
BlockId removal: refactor: BlockBackend::block|block_status#13014
Merged
paritytech-processbot[bot] merged 5 commits intomasterfrom Jan 2, 2023
Merged
BlockId removal: refactor: BlockBackend::block|block_status#13014paritytech-processbot[bot] merged 5 commits intomasterfrom
paritytech-processbot[bot] merged 5 commits intomasterfrom
Conversation
It changes the arguments of: - `BlockBackend::block` - `BlockBackend::block_status` method from: `BlockId<Block>` to: `Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)
michalkucharczyk
added
B0-silent
This was referenced Dec 23, 2022
dmitry-markin
approved these changes
Dec 23, 2022
bkchr
approved these changes
Dec 23, 2022
melekes
approved these changes
Dec 26, 2022
Contributor
melekes
left a comment
melekes
left a comment
There was a problem hiding this comment.
👍 (code-wise; don't know enough to reason about business logic)
Co-authored-by: Bastian Köcher <git@kchr.de>
Contributor
Author
|
bot rebase |
|
Rebased |
Contributor
Author
|
bot merge |
|
Error: "Check reviews" status is not passing for paritytech/cumulus#2041 |
Contributor
Author
|
bot merge |
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
…ch#13014) * BlockId removal: refactor: BlockBackend::block|block_status It changes the arguments of: - `BlockBackend::block` - `BlockBackend::block_status` method from: `BlockId<Block>` to: `Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * non-obvious reworks * doc fix * Apply suggestions from code review Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: parity-processbot <>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…ch#13014) * BlockId removal: refactor: BlockBackend::block|block_status It changes the arguments of: - `BlockBackend::block` - `BlockBackend::block_status` method from: `BlockId<Block>` to: `Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * non-obvious reworks * doc fix * Apply suggestions from code review Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: parity-processbot <>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It changes the arguments of:
BlockBackend::blockBlockBackend::block_statusmethod from:
BlockId<Block>to:Block::HashThis PR is part of BlockId::Number refactoring analysis (paritytech/polkadot-sdk#53)
polkadot companion: paritytech/polkadot#6477
cumulus companion: paritytech/cumulus#2041