Selectable on-runtime-upgrade checks by ggwpez · Pull Request #13045 · paritytech/substrate

ggwpez · 2023-01-02T21:50:57Z

🚨 breaking changes:

frame_try_runtime::TryRuntime::on_runtime_upgrade changes its argument type from bool to UpgradeCheckSelect. See the companion for an integration example.

Non breaking:

try-runtime-cli: The --checks arg of on-runtime-upgrade now also accepts: all, none, pre-and-post and try-state to select the check to run, instead of running all. The values need to be passed with an =.

This makes the type of checks selectable, which is desirable for faster testing since the try-state can take up to two hours for Polkadot when you only want to test the pre- and post-hooks.

(The CI does not realize it needs a companion, but it does)
Polkadot companion: paritytech/polkadot#6498

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

frame/support/src/traits/try_runtime.rs

utils/frame/try-runtime/cli/src/commands/on_runtime_upgrade.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

utils/frame/try-runtime/cli/src/commands/on_runtime_upgrade.rs

This reverts commit e29538c.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

…ech/substrate into oty-try-runtime-cli-select-check

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

bkchr · 2023-01-03T22:49:26Z

utils/frame/try-runtime/cli/src/commands/on_runtime_upgrade.rs

+	#[clap(long,
+		default_value = "None",
+		default_missing_value = "All",
+		num_args = 0..=1,


We don't need this or? default_value should indicate this?

could also use some context on what these flags do, but I believe they help us remain backwards compat.

It is needed since otherwise it does not work as flag without arg. The difference in the help print:
--checks=<CHECKS> (without num_args)
vs
--checks[=<CHECKS>] (with num_args)

I added a comment.

bkchr · 2023-01-03T22:49:49Z

frame/nomination-pools/src/lib.rs


 		for id in reward_pools {
 			let account = Self::create_reward_account(id);
-			assert!(


Why did you removed the assert?

I did, it does not hold anymore because we changed ED in Kusama :(

Context paritytech/polkadot#6372 (comment)

kianenigma · 2023-01-04T10:52:12Z

(The CI does not realize it needs a companion, but it does)

The CI also does not realize that this needs a cumulus companion.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2023-01-04T12:44:32Z

bot merge

@weichweich

## fixes KILTProtocol/ticket#2392 ## Breaking Changes for us ~~None! 🥳~~ Edit: Forgot to also check with try-runtime feature enabled. There is a small tweak necessary because of [This PR about on-runtime-upgrade](paritytech/substrate#13045) No database migrations, no runtime migrations and no new host functions. ## Polkadot Release Link https://github.com/paritytech/polkadot/releases/tag/v0.9.37 ## Release Analysis Forum Post https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-37/1736 ## Cool new stuff that might be useful (or not) * [frame_support::storage: Add StorageStreamIter](paritytech/substrate#12721) * If we have a StorageValue that contains something iterable, we can directly iterate over it, without copying the memory first by a regular get() call. * [Add ensure_* mathematical methods](paritytech/substrate#12754) * The checked_* family of calls returns an Option which is in 99% of the cases mapped to an error * ensure_* calls directly return an error which can be propagated using questionmark operator more easily * [Kusama shows how to express complex local origins in XCM messages](paritytech/polkadot#6273) * Perhaps the most interesting one in this release, would be a good idea for @weichweich and @ntn-x2 to have a look into this * [pallet_uniques successor NFTv2 is out! 🥳 😄 ](paritytech/substrate#12765) * Finally we can have NFTs with owner controlled metadata on our chain. * They even literally mention that this way users can write DIDs directly on their NFT!

* Make try-runtime checks selectable Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/support/src/traits/try_runtime.rs Co-authored-by: Bastian Köcher <git@kchr.de> * Add Clap wrapper for enum UpgradeCheckSelect Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Revert "Add Clap wrapper for enum UpgradeCheckSelect" This reverts commit e29538c. * fix pools sanity check * Set default for --checks to None Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Make --checks backwards comp Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add clap attr comment Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: kianenigma <kian@parity.io>

Make try-runtime checks selectable

33c01bb

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez added B5-clientnoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jan 2, 2023

ggwpez requested a review from kianenigma January 2, 2023 21:50

github-actions bot added the A0-please_review Pull request needs code review. label Jan 2, 2023

ggwpez added the A7-needspolkadotpr label Jan 2, 2023

ggwpez mentioned this pull request Jan 2, 2023

WIP: Run try-runtime hooks in CI paritytech/polkadot#6491

Closed

bkchr approved these changes Jan 2, 2023

View reviewed changes

frame/support/src/traits/try_runtime.rs Outdated Show resolved Hide resolved

utils/frame/try-runtime/cli/src/commands/on_runtime_upgrade.rs Outdated Show resolved Hide resolved

ggwpez and others added 2 commits January 3, 2023 12:49

Update frame/support/src/traits/try_runtime.rs

1f9eb3a

Co-authored-by: Bastian Köcher <git@kchr.de>

Add Clap wrapper for enum UpgradeCheckSelect

e29538c

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

kianenigma reviewed Jan 3, 2023

View reviewed changes

utils/frame/try-runtime/cli/src/commands/on_runtime_upgrade.rs Outdated Show resolved Hide resolved

ggwpez and others added 6 commits January 3, 2023 14:41

Revert "Add Clap wrapper for enum UpgradeCheckSelect"

fbd6724

This reverts commit e29538c.

fix pools sanity check

d32ae61

Set default for --checks to None

d6b2f4d

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Merge branch 'oty-try-runtime-cli-select-check' of github.com:parityt…

9142400

…ech/substrate into oty-try-runtime-cli-select-check

Merge branch 'oty-try-runtime-cli-select-check' of github.com:parityt…

f8b3069

…ech/substrate into oty-try-runtime-cli-select-check

Make --checks backwards comp

ca27a6a

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez added A7-needspolkadotpr and removed A7-needspolkadotpr labels Jan 3, 2023

ggwpez mentioned this pull request Jan 3, 2023

Co #13045: Selectable on-runtime-upgrade checks paritytech/polkadot#6498

Merged

bkchr reviewed Jan 3, 2023

View reviewed changes

kianenigma approved these changes Jan 4, 2023

View reviewed changes

Add clap attr comment

7269f21

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

paritytech-processbot bot merged commit a052224 into master Jan 4, 2023

paritytech-processbot bot deleted the oty-try-runtime-cli-select-check branch January 4, 2023 12:44

ggwpez mentioned this pull request Jan 4, 2023

Co #6498: Selectable on-runtime-upgrade checks paritytech/cumulus#2057

Merged

Dengjianping mentioned this pull request Jan 17, 2023

The param in on_runtime_upgrade has been changed from bool to enum UpgradeCheckSelect Manta-Network/Manta#993

Open

trusch mentioned this pull request Jan 23, 2023

feat: bump polkadot versions to v0.9.37 KILTprotocol/kilt-node#452

Merged

6 tasks

librelois mentioned this pull request Jan 23, 2023

Update substrate/polkadot/cumulus from v0.9.32 to v0.9.37 moonbeam-foundation/moonbeam#2059

Closed

jasl mentioned this pull request Jan 30, 2023

Upgrade to Polkadot v0.9.37 Phala-Network/khala-parachain#249

Merged

hqwangningbo mentioned this pull request Feb 1, 2023

Upgrade to polkadot-v0.9.37 bifrost-io/bifrost#888

Merged

aurexav mentioned this pull request Feb 8, 2023

To polkadot-v0.9.37 darwinia-network/darwinia-2.0#267

Closed

kacperzuk-neti mentioned this pull request Feb 14, 2023

Polkadot v0.9.37 (pallet-nfts) liberland/liberland_substrate#244

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Selectable on-runtime-upgrade checks#13045

Selectable on-runtime-upgrade checks#13045
paritytech-processbot[bot] merged 10 commits intomasterfrom
oty-try-runtime-cli-select-check

ggwpez commented Jan 2, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkchr Jan 3, 2023

Uh oh!

kianenigma Jan 4, 2023

Uh oh!

ggwpez Jan 4, 2023 •

edited

Loading

Uh oh!

bkchr Jan 3, 2023

Uh oh!

kianenigma Jan 4, 2023

Uh oh!

ggwpez Jan 4, 2023

Uh oh!

kianenigma commented Jan 4, 2023

Uh oh!

ggwpez commented Jan 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ggwpez commented Jan 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkchr Jan 3, 2023

Choose a reason for hiding this comment

Uh oh!

kianenigma Jan 4, 2023

Choose a reason for hiding this comment

Uh oh!

ggwpez Jan 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bkchr Jan 3, 2023

Choose a reason for hiding this comment

Uh oh!

kianenigma Jan 4, 2023

Choose a reason for hiding this comment

Uh oh!

ggwpez Jan 4, 2023

Choose a reason for hiding this comment

Uh oh!

kianenigma commented Jan 4, 2023

Uh oh!

ggwpez commented Jan 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ggwpez commented Jan 2, 2023 •

edited

Loading

ggwpez Jan 4, 2023 •

edited

Loading