This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Disallow burning externally locked nfts#13054
Merged
paritytech-processbot[bot] merged 2 commits intomasterfrom Jan 4, 2023
Merged
Disallow burning externally locked nfts#13054paritytech-processbot[bot] merged 2 commits intomasterfrom
paritytech-processbot[bot] merged 2 commits intomasterfrom
Conversation
jsidorenko
added
A0-please_review
joepetrowski
approved these changes
Jan 3, 2023
gilescope
approved these changes
Jan 3, 2023
Contributor
Author
|
bot merge |
Contributor
|
@jsidorenko One question: In the pallet-uniques the |
Contributor
Author
|
Hi, according to the current design, the collection could be removed (destroyed) entirely by the owner regardless of the status of the items. In this PR I made it not possible to burn an item if it was externally locked by some other pallet (like a fractionalization pallet). |
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
* Disallow burning externally locked nfts * Update docs
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Disallow burning externally locked nfts * Update docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the NFT was locked externally via the Locker trait, the owner shouldn't be able to burn it.