This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Scheduler pre block limit note#13231
Merged
paritytech-processbot[bot] merged 4 commits intomasterfrom Apr 3, 2023
Merged
Conversation
muharem
added
A0-please_review
ggwpez
reviewed
Jan 24, 2023
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
Author
|
bot rebase |
…er-block-limit-docs
|
Rebased |
ggwpez
approved these changes
Mar 29, 2023
Contributor
Author
|
bot rebase |
…er-block-limit-docs
|
Rebased |
Contributor
Author
|
bot rebase |
…er-block-limit-docs
|
Rebased |
tonyalaribe
approved these changes
Apr 3, 2023
Contributor
Author
|
bot merge |
paritytech-processbot
bot
deleted the
muharem-scheduler-per-block-limit-docs
branch
gpestana
pushed a commit
that referenced
this pull request
Apr 23, 2023
Co-authored-by: parity-processbot <>
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
Co-authored-by: parity-processbot <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduler has the upper limit for the number of the calls scheduled per block.
The benchmarks of the
pallet_referendaandpallet_conviction_votingdo not respect the limit and overflows it if the schedulerMaxScheduledPerBlocknot high enough.For
pallet_referendabenchmarks the limit reached iftrack.max_deciding > scheduler.max_scheduled_per_block OR
referenda.max_queued > scheduler.max_scheduled_per_block OR
track.max_deciding + referenda.max_queued > scheduler.max_scheduled_per_block
For
pallet_conviction_votingbenchmarks the limit reached ifnumber_of_registered_votes > scheduler.max_scheduled_per_block
This PR is an alternative solution to a more complex one (#13143), helping a user to find a workaround faster.