Max class voters for ranked collective vote tally

[muharem]

The implementation of VoteTally trait, uses Rank type where Class is supposed.
For Kusama runtime, this is not an issue. The Rank and Class is the same u16 type and mapped 1:1.

But if,

• the mapping is not 1:1, the max voters count might be wrong;
• Class is any other type (e.g. enum), it wont compile.

// DONE tests

[gavofyork]

Looks ok in general, but are Rank and Class not already defined as equivalent within ranked-collective's VoteTally impl because its Class generic parameter is provided as Rank?

[muharem]

Looks ok in general, but are Rank and Class not already defined as equivalent within ranked-collective's VoteTally impl because its Class generic parameter is provided as Rank?

I see it now.
It not simple to read it like that. Here for example we access Class type throughout Polling trait, signaling its generic for the pallet -

substrate/frame/ranked-collective/src/lib.rs

Line 343 in 37e3abd

type MinRankOfClass: Convert<<Self::Polls as Polling<TallyOf<Self, I>>>::Class, Rank>;

The signatures of the VoteTally funcs impls becomes confusing to me, the name of the arg is class, the type is Rank, but docs will help -

substrate/frame/ranked-collective/src/lib.rs

Line 140 in 37e3abd

fn rejection(class: Rank) -> Self {

I faced the issue, while trying to define the Class as enum.
We can go either way, generic class (like in the PR now) or class type is rank type, but I make it more explicit and add some docs.

[muharem]

bot rebase

[paritytech-processbot]

Rebased

[juangirini]

bot rebase

[paritytech-processbot]

Rebased

[ggwpez]

Just one comment.

[ggwpez]

Just one comment.

[muharem]

bot merge

[paritytech-processbot]

Waiting for commit status.