This repository was archived by the owner on Nov 15, 2023. It is now read-only.
babe: account for skipped epochs when handling equivocations#13335
Merged
paritytech-processbot[bot] merged 3 commits intomasterfrom Feb 17, 2023
Merged
Conversation
andresilva
added
B0-silent
andresilva
added
the
C1-low
davxy
approved these changes
Feb 8, 2023
bkchr
approved these changes
Feb 9, 2023
Contributor
Author
|
bot merge |
paritytech-processbot
bot
deleted the
andre/babe-equivocation-handling-skipped-epochs
branch
rossbulat
pushed a commit
that referenced
this pull request
Feb 19, 2023
* babe: account for skipped epochs when handling equivocations * typos * babe: enforce epoch index >= session index
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
…ech#13335) * babe: account for skipped epochs when handling equivocations * typos * babe: enforce epoch index >= session index
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…ech#13335) * babe: account for skipped epochs when handling equivocations * typos * babe: enforce epoch index >= session index
Ank4n
pushed a commit
that referenced
this pull request
Feb 28, 2023
* babe: account for skipped epochs when handling equivocations * typos * babe: enforce epoch index >= session index
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 10, 2023
…ech#13335) * babe: account for skipped epochs when handling equivocations * typos * babe: enforce epoch index >= session index
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…ech#13335) * babe: account for skipped epochs when handling equivocations * typos * babe: enforce epoch index >= session index
Closed
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When validating an equivocation proof we need to validate a key ownership proof for the validator that committed the offence at a given epoch. The key ownership proof exists in the context of a given session, therefore we must also validate the mapping between an epoch and a session. Normally these are synced (i.e.
epoch index == session index), but if epochs are skipped this invariant is broken. This PR adds tracking of skipped epochs so that we can properly validate equivocation proofs after epochs are skipped.