Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

add ensure_dispatch_as that propagates errors#13387

Closed
sander2 wants to merge 1 commit intoparitytech:masterfrom
interlay:fix/ensure-dispatch-as
Closed

add ensure_dispatch_as that propagates errors#13387
sander2 wants to merge 1 commit intoparitytech:masterfrom
interlay:fix/ensure-dispatch-as

Conversation

@sander2
Copy link
Contributor

@sander2 sander2 commented Feb 14, 2023 •
edited by ggwpez
Loading

Addresses paritytech/polkadot-sdk#219

This adds a new function utility.ensure_dispatch_as that is like utility.dispatch_as, except that it propagates errors returned by the wrapped call.

Polkadot companion: paritytech/polkadot#6723
Cumulus companion: paritytech/cumulus#2188

ggwpez
ggwpez reviewed Feb 14, 2023
View reviewed changes
@ggwpez ggwpez added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B1-note_worthy Changes should be noted in the release notes T1-runtime This PR/Issue is related to the topic “runtime”. labels Feb 14, 2023
@sander2 sander2 force-pushed the fix/ensure-dispatch-as branch from 52c75b7 to a58abd3 Compare February 15, 2023 09:15
@ggwpez
Copy link
Member

ggwpez commented Feb 15, 2023

It needs a Polkadot and Cumulus companion. You can just copy the Substrate weights into their weight files to make it compile.

This was referenced Feb 15, 2023
Open
Open
@sander2
Copy link
Contributor Author

sander2 commented Feb 15, 2023

It needs a Polkadot and Cumulus companion. You can just copy the Substrate weights into their weight files to make it compile.

Ok, I made the companion prs. I used the weights of dispatch_as of their respective runtimes, since it's pretty much the same weight.

@ggwpez
Copy link
Member

ggwpez commented Feb 22, 2023

Ok, I made the companion prs. I used the weights of dispatch_as of their respective runtimes, since it's pretty much the same weight.

Okay I updated the MR description to mention them. Let's see if the CI goes green.

@stale
Copy link

stale bot commented Mar 25, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Mar 25, 2023
@stale stale bot closed this Apr 8, 2023
@0xmovses 0xmovses mentioned this pull request Oct 19, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@xlc xlc xlc left review comments

@ggwpez ggwpez ggwpez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. A3-stale B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sander2 @ggwpez @xlc