This repository was archived by the owner on Nov 15, 2023. It is now read-only.
BlockId removal: BlockBuilderProvider::new_block_at#13401
Merged
paritytech-processbot[bot] merged 6 commits intomasterfrom Feb 21, 2023
Merged
BlockId removal: BlockBuilderProvider::new_block_at#13401paritytech-processbot[bot] merged 6 commits intomasterfrom
BlockId removal: BlockBuilderProvider::new_block_at#13401paritytech-processbot[bot] merged 6 commits intomasterfrom
Conversation
It changes the arguments of `BlockBuilderProvider::new_block_at` from: `BlockId<Block>` to: `Block::Hash`
michalkucharczyk
requested review from
acatangiu and
andresilva
as code owners
michalkucharczyk
added
B0-silent
| let params = BlockCheckParams { | ||
| hash: block_ok.hash(), | ||
| number: 0, | ||
| number: 1, |
Contributor
Author
There was a problem hiding this comment.
note: Actually number given here does not matter, but the code is less confusing if the number actually matches the checked block.
| }; | ||
| if record_only { | ||
| fork_rules.push((1, block_ok.hash())); | ||
| fork_rules.push((2, block_ok.hash())); |
Contributor
Author
There was a problem hiding this comment.
note: Checking fork at block height 2 is more readable and less confusing, this is inline with actual block number, and also with params passed to check_block.
bkchr
approved these changes
Feb 16, 2023
This was referenced Feb 21, 2023
skunert
approved these changes
Feb 21, 2023
Contributor
Author
|
bot merge |
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
…3401) * `BlockId` removal: `BlockBuilderProvider::new_block_at` It changes the arguments of `BlockBuilderProvider::new_block_at` from: `BlockId<Block>` to: `Block::Hash` * fmt * fix * more fixes
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…3401) * `BlockId` removal: `BlockBuilderProvider::new_block_at` It changes the arguments of `BlockBuilderProvider::new_block_at` from: `BlockId<Block>` to: `Block::Hash` * fmt * fix * more fixes
Ank4n
pushed a commit
that referenced
this pull request
Feb 28, 2023
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 10, 2023
…3401) * `BlockId` removal: `BlockBuilderProvider::new_block_at` It changes the arguments of `BlockBuilderProvider::new_block_at` from: `BlockId<Block>` to: `Block::Hash` * fmt * fix * more fixes
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…3401) * `BlockId` removal: `BlockBuilderProvider::new_block_at` It changes the arguments of `BlockBuilderProvider::new_block_at` from: `BlockId<Block>` to: `Block::Hash` * fmt * fix * more fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It changes the arguments of
BlockBuilderProvider::new_block_atfrom:BlockId<Block>to:Block::HashThis PR is part of BlockId::Number refactoring analysis (paritytech/polkadot-sdk#53)
polkadot companion: paritytech/polkadot#6734
cumulus companion: paritytech/cumulus#2219