Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Ranked Collective: constructor for MemberRecord#13473

Merged
paritytech-processbot[bot] merged 1 commit intomasterfrom
muharem-member-record-constructor
Feb 27, 2023
Merged

Ranked Collective: constructor for MemberRecord#13473
paritytech-processbot[bot] merged 1 commit intomasterfrom
muharem-member-record-constructor

Conversation

@muharem
Copy link
Contributor

@muharem muharem commented Feb 26, 2023

The rank field of MemberRecord is private.
I need to construct the MemberRecord outside of the pallet, for a migration.
I propose to introduce a constructor.

required for paritytech/cumulus#2236

@muharem muharem added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Feb 26, 2023
@ggwpez
Copy link
Member

ggwpez commented Feb 27, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 1cbb2ef into master Feb 27, 2023
@paritytech-processbot paritytech-processbot bot deleted the muharem-member-record-constructor branch February 27, 2023 16:41
ukint-vs pushed a commit to gear-tech/substrate that referenced this pull request Apr 10, 2023
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants