This repository was archived by the owner on Nov 15, 2023. It is now read-only.
frame epm: expose feasibility_check in MinerConfig#13555
Merged
paritytech-processbot[bot] merged 3 commits intomasterfrom Mar 14, 2023
Merged
frame epm: expose feasibility_check in MinerConfig#13555paritytech-processbot[bot] merged 3 commits intomasterfrom
feasibility_check in MinerConfig#13555paritytech-processbot[bot] merged 3 commits intomasterfrom
Conversation
The goal with this commit is to expose the `feasibity_check` such that anyone that implements the `MinerConfig trait` can utilize it
niklasad1
changed the title
kianenigma
approved these changes
Mar 7, 2023
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Acceptable, let's proceed.
niklasad1
added
A0-please_review
niklasad1
changed the title
feasibility_check in MinerConfig
niklasad1
commented
Mar 8, 2023
| pub static MaxElectingVoters: VoterIndex = u32::max_value(); | ||
| pub static MaxElectableTargets: TargetIndex = TargetIndex::max_value(); | ||
|
|
||
| #[derive(Debug)] |
Contributor
Author
There was a problem hiding this comment.
I was forced to add this Debug bound I suspect it's because rustc resolved it before as this was part of the Config trait.
Only relevant for tests anyway so should be a big deal
lexnv
approved these changes
Mar 8, 2023
Contributor
Author
|
bot merge |
|
Error: "Check reviews" status is not passing for paritytech/polkadot#6842 |
Contributor
Author
|
bot merge |
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 10, 2023
* frame epm: expose feasibity_check in miner The goal with this commit is to expose the `feasibity_check` such that anyone that implements the `MinerConfig trait` can utilize it * cleanup * fix tests
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* frame epm: expose feasibity_check in miner The goal with this commit is to expose the `feasibity_check` such that anyone that implements the `MinerConfig trait` can utilize it * cleanup * fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal with this commit is to expose the
feasibility_checksuch that anyone that implements theMinerConfig traitcan utilize it.polkadot companion: paritytech/polkadot#6842