This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Nfts: minor fixes#13576
Merged
paritytech-processbot[bot] merged 2 commits intomasterfrom Mar 10, 2023
Merged
Conversation
jsidorenko
added
A0-please_review
gilescope
approved these changes
Mar 10, 2023
muharem
approved these changes
Mar 10, 2023
Contributor
muharem
left a comment
muharem
left a comment
There was a problem hiding this comment.
@jsidorenko review the labels, this is breaking api changes
jsidorenko
added
B1-note_worthy
Contributor
Author
|
bot merge |
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 10, 2023
* Rename owner_of_item to owned_item * Move AttributeNamespace into the types file
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Rename owner_of_item to owned_item * Move AttributeNamespace into the types file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let MintWitness { owner_of_item }tolet MintWitness { owned_item }Since we need to specify here item's id, and not the owner
AttributeNamespacedefined in a general file in order to use them in nonfungible traits, but later we removed that dependency and could safely put that enum back