Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

add a new ci job to fuzz sp-arithmetic#13673

Merged
altaua merged 1 commit intomasterfrom
mira/honggfuzz
Mar 27, 2023
Merged

add a new ci job to fuzz sp-arithmetic#13673
altaua merged 1 commit intomasterfrom
mira/honggfuzz

Conversation

@altaua
Copy link
Contributor

@altaua altaua commented Mar 22, 2023

@altaua altaua added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 22, 2023
@altaua altaua self-assigned this Mar 22, 2023
@altaua altaua force-pushed the mira/honggfuzz branch 26 times, most recently from 076494f to e894f07 Compare March 23, 2023 14:49
@altaua
Copy link
Contributor Author

altaua commented Mar 23, 2023

Using a private fork of honggfuzz-rs for now until upstream merges rust-fuzz/honggfuzz-rs#81 and rust-fuzz/honggfuzz-rs#82.

@altaua altaua changed the title DRAFT: add a new ci job to fuzz sp-arithmetic add a new ci job to fuzz sp-arithmetic Mar 23, 2023
@altaua altaua marked this pull request as ready for review March 23, 2023 15:22
@altaua altaua requested a review from a team as a code owner March 23, 2023 15:22
@altaua altaua added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Mar 23, 2023
@ggwpez
Copy link
Member

ggwpez commented Mar 23, 2023

Okay thanks! The failing fuzzers look good:
image

Maybe you can still run it in a quiet mode, so that the log output is a bit shorter? I did not yet fix the normalize fuzzer, so could be that it still fails after #13659.
Maybe we can make the check optional for now, if it is not fixed before this merges.

@altaua
Copy link
Contributor Author

altaua commented Mar 23, 2023

Maybe you can still run it in a quiet mode, so that the log output is a bit shorter? I did not yet fix the normalize fuzzer, so could be that it still fails after #13659.

Yeah, the log is unpleasantly noisy for sure. Unfortunately, --quiet also hides log messages about crashes encountered during fuzzing, and does /not/ hide the irrelevant internal hongfuzz warning input_getNext():129 No useful files in the input directory.

I didn't want the logs to be empty except for some totally expected warnings, so I chose to leave the job in verbose mode.

Maybe we can make the check optional for now, if it is not fixed before this merges.

Yep, I've tagged it with allow_failure: true, it won't block merges.

Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(Approving from Runtime point of view)

@paritytech-ci paritytech-ci requested a review from a team March 23, 2023 21:49
@altaua
Copy link
Contributor Author

altaua commented Mar 23, 2023

We'll hold off on merging this PR until #13660 lands; beyond that, it's ready.

@ggwpez
Copy link
Member

ggwpez commented Mar 24, 2023

It merged.

bot rebase

@paritytech-processbot
Copy link

Rebased

@paritytech-ci paritytech-ci requested a review from a team March 24, 2023 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants