This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Adds integration test for slashed/chilled validator with subsequent validation intention#13717
Merged
paritytech-processbot[bot] merged 9 commits intomasterfrom May 15, 2023
Merged
Conversation
…alidation intention
gpestana
added
A0-please_review
Ank4n
approved these changes
Mar 27, 2023
Contributor
Author
|
bot rebase |
|
Rebased |
kianenigma
reviewed
May 8, 2023
frame/election-provider-multi-phase/test-staking-e2e/src/mock.rs
Outdated
Show resolved
Hide resolved
kianenigma
reviewed
May 8, 2023
frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs
Outdated
Show resolved
Hide resolved
kianenigma
reviewed
May 8, 2023
| assert_eq!( | ||
| staking_events(), | ||
| [ | ||
| Event::Chilled { stash: 11 }, |
Contributor
There was a problem hiding this comment.
Do we chill under all conditions? I didn't know this off the top of my head.
kianenigma
reviewed
May 8, 2023
frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs
Outdated
Show resolved
Hide resolved
kianenigma
reviewed
May 8, 2023
frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs
Outdated
Show resolved
Hide resolved
kianenigma
approved these changes
May 8, 2023
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
LGTM, just the comment about the CI was concerning.
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for 7f71737 |
Contributor
Author
|
bot rebase |
|
Rebased |
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…alidation intention (paritytech#13717) * Adds integration test for slashed/chilled validator with subsequent validation intention * Removes unecessary comment * Update frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Update frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Addresses PR review comments * Fixes after conflict resolved --------- Co-authored-by: parity-processbot <> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds integration test for case mentioned in paritytech/polkadot-sdk#420