This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Insert claim_commission weight#13774
Merged
paritytech-processbot[bot] merged 1 commit intomasterfrom Apr 1, 2023
Merged
Conversation
rossbulat
added
B0-silent
kianenigma
approved these changes
Apr 1, 2023
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
A good harmless incident to push @paritytech/staking-core myself included to up the review quality further 🆙 ⬆️
Member
|
bot merge |
Member
|
We could forbid hardcoded constant as weignts in non dev-mode pallets. @kianenigma |
pgherveou
pushed a commit
that referenced
this pull request
Apr 4, 2023
gpestana
pushed a commit
that referenced
this pull request
Apr 23, 2023
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/april-updates-for-substrate-and-polkadot-devs/2764/1 |
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
claim_commissiondid not have its calculated weight associated with the call. This PR fixes this.