Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Mention on_idle round-robin logic to trait Hooks cargo doc#13797

Merged
paritytech-processbot[bot] merged 6 commits intomasterfrom
gpestana/on_idle_docs
Apr 5, 2023
Merged

Mention on_idle round-robin logic to trait Hooks cargo doc#13797
paritytech-processbot[bot] merged 6 commits intomasterfrom
gpestana/on_idle_docs

Conversation

@gpestana
Copy link
Contributor

@gpestana gpestana commented Apr 1, 2023

Improves cargo doc comments of trait Hooks to include the logic related to calling the runtime pallets' on_idle hooks using round-robin.

@gpestana gpestana added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”. labels Apr 1, 2023
@gpestana gpestana requested review from a team, KiChjang, ggwpez and kianenigma April 1, 2023 12:58
@gpestana gpestana self-assigned this Apr 1, 2023
Ank4n
Ank4n reviewed Apr 1, 2023
View reviewed changes
@gpestana gpestana requested a review from Ank4n April 1, 2023 14:25
bkchr
bkchr approved these changes Apr 1, 2023
View reviewed changes
gpestana and others added 2 commits April 2, 2023 06:39
@gpestana @bkchr
Update frame/support/src/traits/hooks.rs
4abfe1f 
Co-authored-by: Bastian Köcher <git@kchr.de>
@gpestana
fmt
492813f
@ruseinov ruseinov self-requested a review April 2, 2023 15:09
@gpestana
Copy link
Contributor Author

gpestana commented Apr 3, 2023

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented Apr 3, 2023

Error: Statuses failed for 492813f

@gpestana
Copy link
Contributor Author

gpestana commented Apr 3, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Apr 3, 2023 •
edited
Loading

@gpestana https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2632466 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 41-2b33f999-1201-44eb-83c9-f84eacd2e008 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Apr 3, 2023

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2632466 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2632466/artifacts/download.

@gpestana
Copy link
Contributor Author

gpestana commented Apr 4, 2023

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented Apr 4, 2023

Error: Statuses failed for 492813f

@gpestana
Copy link
Contributor Author

gpestana commented Apr 4, 2023

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented Apr 4, 2023

Waiting for commit status.

@paritytech-processbot
Copy link

paritytech-processbot bot commented Apr 4, 2023

Merge cancelled due to error. Error: Statuses failed for 8a9a45b

@gpestana
Copy link
Contributor Author

gpestana commented Apr 5, 2023

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented Apr 5, 2023

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 5380a9a into master Apr 5, 2023
@paritytech-processbot paritytech-processbot bot deleted the gpestana/on_idle_docs branch April 5, 2023 13:14
gpestana added a commit that referenced this pull request Apr 23, 2023
@gpestana @bkchr
Mention on_idle round-robin logic to trait Hooks cargo doc (#13797)
5b508e9 
* Adds on_idle round-robin logic to trait Hooks docs

* Makes the docs more concise

* Update frame/support/src/traits/hooks.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* fmt

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@gpestana @bkchr @nathanwhit
Mention on_idle round-robin logic to trait Hooks cargo doc (parit…
0b1ee1b 
…ytech#13797)

* Adds on_idle round-robin logic to trait Hooks docs

* Makes the docs more concise

* Update frame/support/src/traits/hooks.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* fmt

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kianenigma kianenigma Awaiting requested review from kianenigma

@ggwpez ggwpez Awaiting requested review from ggwpez

4 more reviewers

@ruseinov ruseinov ruseinov approved these changes

@KiChjang KiChjang KiChjang approved these changes

@bkchr bkchr bkchr approved these changes

@Ank4n Ank4n Ank4n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gpestana gpestana

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gpestana @ruseinov @KiChjang @bkchr @Ank4n