This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Update the frame-weight-template to use PhantomData from core#13844
Merged
paritytech-processbot[bot] merged 2 commits intomasterfrom Apr 6, 2023
Merged
Conversation
AlexD10S
added
B0-silent
ggwpez
reviewed
Apr 6, 2023
bkchr
approved these changes
Apr 6, 2023
ggwpez
approved these changes
Apr 6, 2023
ggwpez
added
A0-please_review
Member
|
bot merge |
paritytech-processbot
bot
deleted the
alexd10s-modify-weights-template-imports
branch
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…tech#13844) * update weights template and recalculate weights from pallet template * update template file in benchmarking-cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the file
frame-weight-template.hbsto usecore::marker::PhantomDatainstead ofsp_std::marker::PhantomData, so no need to import the sp-std just for this type.And updated manually the pallet_template from the node_template.
This change was suggested in a comment in this PR #13817