This repository was archived by the owner on Nov 15, 2023. It is now read-only.
HoldReason: Improve usage#13869
Merged
paritytech-processbot[bot] merged 5 commits intomasterfrom May 24, 2023
Merged
Conversation
`HoldReason` was switched recently to use the `composite_enum` attribute that will merge the enums from all pallets in the runtime to `RuntimeHoldReason`. `pallet-nis` was still requiring that the variant was passed as constant to call `hold`. The proper implementation is to use the `HoldReason` from inside the pallet directly when calling `hold`. This is done by adding a `RuntimeHoldReason` as type to the `Config` trait and requiring that `Currency` is using the same reason. Besides that the pr changes the name `HoldIdentifier` in `pallet_balances::Config` to `RuntimeHoldReason`.
bkchr
added
A0-please_review
bkchr
added
the
D3-trivial 🧸
ggwpez
reviewed
Apr 11, 2023
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
approved these changes
Apr 11, 2023
KiChjang
approved these changes
Apr 12, 2023
Contributor
KiChjang
left a comment
KiChjang
left a comment
There was a problem hiding this comment.
Not sure if Gav would approve the name change from HoldIdentifier to RuntimeHoldReason, but LGTM otherwise.
Member
Author
Naming here just follows |
bkchr
added a commit
to paritytech/polkadot
that referenced
this pull request
Apr 23, 2023
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
jsidorenko
approved these changes
May 24, 2023
Contributor
|
Do we need to open a cumulus companion PR? |
Member
Author
Yes, I will do this shortly. Was the fractionalization already released on Westmint? |
Contributor
|
the companion PR was merged yesterday |
bkchr
added a commit
to paritytech/cumulus
that referenced
this pull request
May 24, 2023
sam0x17
approved these changes
May 24, 2023
Member
Author
|
bot merge |
paritytech-processbot bot
pushed a commit
to paritytech/polkadot
that referenced
this pull request
May 24, 2023
* Companion: Substrate#13869 paritytech/substrate#13869 * update lockfile for {"substrate"} * ".git/.scripts/commands/fmt/fmt.sh" --------- Co-authored-by: parity-processbot <>
paritytech-processbot bot
pushed a commit
to paritytech/cumulus
that referenced
this pull request
May 24, 2023
* Companion for: Substrate#13869 paritytech/substrate#13869 * Fix * Warning * update lockfile for {"polkadot", "substrate"} --------- Co-authored-by: parity-processbot <>
ggwpez
pushed a commit
to ggwpez/runtimes
that referenced
this pull request
Jul 6, 2023
* Companion for: Substrate#13869 paritytech/substrate#13869 * Fix * Warning * update lockfile for {"polkadot", "substrate"} --------- Co-authored-by: parity-processbot <>
ggwpez
pushed a commit
to ggwpez/runtimes
that referenced
this pull request
Jul 6, 2023
* Companion for: Substrate#13869 paritytech/substrate#13869 * Fix * Warning * update lockfile for {"polkadot", "substrate"} --------- Co-authored-by: parity-processbot <>
Ank4n
pushed a commit
that referenced
this pull request
Jul 8, 2023
* HoldReason: Improve usage `HoldReason` was switched recently to use the `composite_enum` attribute that will merge the enums from all pallets in the runtime to `RuntimeHoldReason`. `pallet-nis` was still requiring that the variant was passed as constant to call `hold`. The proper implementation is to use the `HoldReason` from inside the pallet directly when calling `hold`. This is done by adding a `RuntimeHoldReason` as type to the `Config` trait and requiring that `Currency` is using the same reason. Besides that the pr changes the name `HoldIdentifier` in `pallet_balances::Config` to `RuntimeHoldReason`. * Update frame/nis/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Review comment * Fixes --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
pushed a commit
to ggwpez/runtimes
that referenced
this pull request
Jul 13, 2023
* Companion: Substrate#13869 paritytech/substrate#13869 * update lockfile for {"substrate"} * ".git/.scripts/commands/fmt/fmt.sh" --------- Co-authored-by: parity-processbot <>
ggwpez
pushed a commit
to ggwpez/runtimes
that referenced
this pull request
Jul 13, 2023
* Companion for: Substrate#13869 paritytech/substrate#13869 * Fix * Warning * update lockfile for {"polkadot", "substrate"} --------- Co-authored-by: parity-processbot <>
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* HoldReason: Improve usage `HoldReason` was switched recently to use the `composite_enum` attribute that will merge the enums from all pallets in the runtime to `RuntimeHoldReason`. `pallet-nis` was still requiring that the variant was passed as constant to call `hold`. The proper implementation is to use the `HoldReason` from inside the pallet directly when calling `hold`. This is done by adding a `RuntimeHoldReason` as type to the `Config` trait and requiring that `Currency` is using the same reason. Besides that the pr changes the name `HoldIdentifier` in `pallet_balances::Config` to `RuntimeHoldReason`. * Update frame/nis/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Review comment * Fixes --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HoldReasonwas switched recently to use thecomposite_enumattribute that will merge the enums from all pallets in the runtime toRuntimeHoldReason.pallet-niswas still requiring that the variant was passed as constant to callhold. The proper implementation is to use theHoldReasonfrom inside the pallet directly when callinghold. This is done by adding aRuntimeHoldReasonas type to theConfigtrait and requiring thatCurrencyis using the same reason. Besides that the pr changes the nameHoldIdentifierinpallet_balances::ConfigtoRuntimeHoldReason.Downstream code changes
For the
pallet_balances::Configtrait you need to changeHoldIdentifiertoRuntimeHoldReasonand pass theRuntimeHoldReasonthat is being generated byconstruct_runtime!.For the
pallet_nis::Configtrait you need to removeHoldReasonas this is not being handled internally of the pallet, but you need to addRuntimeHoldReasonwhich you also need to set toRuntimeHoldReasonthat is being generated byconstruct_runtime!.polkadot companion: paritytech/polkadot#7119
cumulus companion: paritytech/cumulus#2631