Benchmark pallet sudo by Doordashcon · Pull Request #13880 · paritytech/substrate

Doordashcon · 2023-04-11T15:12:41Z

polkadot companion: paritytech/polkadot#7118
cumulus companion: paritytech/cumulus#2514
polkadot address: 12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h

frame/sudo/src/benchmarking.rs

…o ddc-OG

Doordashcon · 2023-04-18T21:40:13Z

Hello @ggwpez, does the benchmark bot handle generating the weights.rs file?

ggwpez · 2023-04-19T14:54:01Z

bot bench $ runtime dev pallet_sudo

Hello @ggwpez, does the benchmark bot handle generating the weights.rs file?
Yes, lets see if it can push to your branch.

ggwpez · 2023-04-19T15:02:08Z

bot clean
bot bench $ pallet dev pallet_sudo

command-bot · 2023-04-19T15:02:21Z

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2703621 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_sudo. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 40-511d547c-0799-41cb-b776-c4d3a5ade0f0 to cancel this command or bot cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2023-04-19T15:27:44Z

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_sudo has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2703621 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2703621/artifacts/download.

frame/sudo/src/lib.rs

ggwpez

Thanks!
The sudo and sudo_as could also use a benchmark, but this is a good start.

frame/sudo/src/lib.rs

frame/sudo/src/benchmarking.rs

muharem · 2023-04-26T13:41:56Z

@Doordashcon also needs companion PR for cumulus.
please make sure you get all approves for companions before merging.

ggwpez · 2023-05-09T11:23:15Z

bot bench $ pallet dev pallet_sudo

command-bot · 2023-05-09T11:23:20Z

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2804254 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_sudo. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 24-da8711ff-f313-4b8a-808f-fcc85b329cd6 to cancel this command or bot cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2023-05-09T13:08:59Z

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_sudo has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2804254 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2804254/artifacts/download.

ggwpez

Companion will need to be updated with the new weight functions, then we should be good.
Thanks!

Doordashcon · 2023-05-10T16:41:05Z

CI is not happy :(

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2023-05-10T20:27:46Z

bot merge

ggwpez · 2023-05-10T20:32:19Z

bot merge

paritytech-processbot · 2023-05-10T20:32:33Z

Error: "Check reviews" status is not passing for paritytech/cumulus#2514

KiChjang · 2023-05-11T13:28:36Z

bot merge

juangirini · 2023-05-11T14:26:58Z

/tip small

substrate-tip-bot · 2023-05-11T14:27:02Z

@juangirini A small tip was successfully submitted for Doordashcon (12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips

* set_key * v2 * update runtime * cargo fmt * remove commenting * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_sudo * impl weights * sudo & sudo_as * where * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_sudo * update weights * cargo fmt * Update Cargo.lock Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: command-bot <> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

set_key

086d363

ggwpez reviewed Apr 11, 2023

View reviewed changes

frame/sudo/src/benchmarking.rs Outdated Show resolved Hide resolved

doordashcon added 4 commits April 18, 2023 20:51

v2

0319a2f

Merge branch 'master' into ddc-OG

6e16a8c

update runtime

6cccbfe

Merge branch 'ddc-OG' of https://github.com/Doordashcon/substrate int…

7b5817b

…o ddc-OG

Doordashcon marked this pull request as ready for review April 18, 2023 20:48

doordashcon added 2 commits April 18, 2023 22:17

cargo fmt

fd71be3

remove commenting

823d98b

command-bot added 2 commits April 19, 2023 15:02

Merge branch 'master' of https://github.com/paritytech/substrate into…

e082fec

… HEAD

".git/.scripts/commands/bench/bench.sh" pallet dev pallet_sudo

5078939

ggwpez reviewed Apr 19, 2023

View reviewed changes

frame/sudo/src/lib.rs Show resolved Hide resolved

doordashcon added 2 commits April 20, 2023 11:27

impl weights

01a597a

Merge branch 'paritytech:master' into ddc-OG

811d52d

Doordashcon mentioned this pull request Apr 23, 2023

Substrate Companion paritytech/polkadot#7118

Merged

Merge branch 'paritytech:master' into ddc-OG

fe6e0a4

ggwpez approved these changes Apr 25, 2023

View reviewed changes

frame/sudo/src/lib.rs Outdated Show resolved Hide resolved

frame/sudo/src/lib.rs Outdated Show resolved Hide resolved

muharem approved these changes Apr 26, 2023

View reviewed changes

frame/sudo/src/benchmarking.rs Outdated Show resolved Hide resolved

muharem removed the B1-note_worthy Changes should be noted in the release notes label Apr 26, 2023

command-bot added 2 commits May 9, 2023 12:43

Merge branch 'master' of https://github.com/paritytech/substrate into…

e38b8a9

… HEAD

".git/.scripts/commands/bench/bench.sh" pallet dev pallet_sudo

891a949

Doordashcon added 2 commits May 9, 2023 22:03

update weights

8ffafdf

cargo fmt

ff180b3

ggwpez approved these changes May 10, 2023

View reviewed changes

Doordashcon added 2 commits May 10, 2023 12:37

Merge branch 'paritytech:master' into ddc-OG

ff4405c

Merge branch 'paritytech:master' into ddc-OG

fc1d8af

Update Cargo.lock

6c3acef

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

paritytech deleted a comment from paritytech-processbot bot May 10, 2023

paritytech-processbot bot merged commit a87e56f into paritytech:master May 11, 2023

github-actions bot mentioned this pull request Jun 15, 2023

Update substrate/polkadot/cumulus from v0.9.40 to v0.9.43 moonbeam-foundation/moonbeam#2354

Closed

gilescope mentioned this pull request Jun 18, 2023

Add sudo to template node paritytech/cumulus#2748

Merged

kiltbot mentioned this pull request Jun 21, 2023

1️⃣ [AUTOMATIC] Update Polkadot dependencies from 0.9.42 to 0.9.43 KILTprotocol/kilt-node#531

Closed

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

aurexav added a commit to darwinia-network/darwinia that referenced this pull request Jul 11, 2023

Companion of paritytech/substrate#13880

d79bf26

Daanvdplas mentioned this pull request Jul 24, 2023

fix: include sudo weights paritytech/extended-parachain-template#48

Closed

dmitrylavrenov mentioned this pull request Oct 29, 2024

Tracking issue to bump substrate related deps to polkadot-v0.9.43 humanode-network/humanode#923

Closed

2 tasks

dmitrylavrenov mentioned this pull request Feb 19, 2025

Bump to polkadot-v0.9.43 as a base for substrate related deps humanode-network/humanode#940

Merged

Conversation

Doordashcon commented Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Doordashcon commented Apr 18, 2023

Uh oh!

ggwpez commented Apr 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ggwpez commented Apr 19, 2023

Uh oh!

command-bot bot commented Apr 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Apr 19, 2023

Uh oh!

Uh oh!

ggwpez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

muharem commented Apr 26, 2023

Uh oh!

ggwpez commented May 9, 2023

Uh oh!

command-bot bot commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented May 9, 2023

Uh oh!

ggwpez left a comment

Choose a reason for hiding this comment

Uh oh!

Doordashcon commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ggwpez commented May 10, 2023

Uh oh!

ggwpez commented May 10, 2023

Uh oh!

paritytech-processbot bot commented May 10, 2023

Uh oh!

KiChjang commented May 11, 2023

Uh oh!

juangirini commented May 11, 2023

Uh oh!

substrate-tip-bot bot commented May 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Doordashcon commented Apr 11, 2023 •

edited

Loading

ggwpez commented Apr 19, 2023 •

edited

Loading

command-bot bot commented Apr 19, 2023 •

edited

Loading

command-bot bot commented May 9, 2023 •

edited

Loading

Doordashcon commented May 10, 2023 •

edited

Loading