This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Implements try_state hook in elections and EPM pallets#13979
Merged
paritytech-processbot[bot] merged 7 commits intomasterfrom Apr 27, 2023
Merged
Implements try_state hook in elections and EPM pallets#13979paritytech-processbot[bot] merged 7 commits intomasterfrom
try_state hook in elections and EPM pallets#13979paritytech-processbot[bot] merged 7 commits intomasterfrom
Conversation
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
gpestana
added
A0-please_review
Contributor
Author
|
@liamaharon I have addressed your comments from the previous review in #13718 and re-opened this new PR. |
Ank4n
reviewed
Apr 23, 2023
Ank4n
reviewed
Apr 23, 2023
Ank4n
reviewed
Apr 23, 2023
Ank4n
reviewed
Apr 23, 2023
Ank4n
reviewed
Apr 23, 2023
Ank4n
reviewed
Apr 23, 2023
Ank4n
reviewed
Apr 23, 2023
liamaharon
approved these changes
Apr 24, 2023
kianenigma
reviewed
Apr 25, 2023
kianenigma
reviewed
Apr 25, 2023
kianenigma
approved these changes
Apr 25, 2023
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
There's some potential follow-up or refactoring to be done, but I think it can be left to the author to decided where/how to proceed, so all good for this one.
Ank4n
approved these changes
Apr 27, 2023
Contributor
Author
|
bot merge |
|
Error: Statuses failed for 216bb85 |
Contributor
Author
|
bot merge |
|
Error: Statuses failed for 216bb85 |
Contributor
Author
|
bot rebase |
|
Rebased |
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
paritytech-processbot
bot
deleted the
gpestana/try_state_elections_final
branch
gpestana
added a commit
that referenced
this pull request
May 4, 2023
* Adds try_state hook to elections pallets * Addresses PR review comments Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> * remove unecessary println * ensures try-runtime does not mutate storage * Addresses PR comments * Fixes snapshot invariant checks; simplifies test infra --------- Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> Co-authored-by: parity-processbot <>
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…13979) * Adds try_state hook to elections pallets * Addresses PR review comments Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> * remove unecessary println * ensures try-runtime does not mutate storage * Addresses PR comments * Fixes snapshot invariant checks; simplifies test infra --------- Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> Co-authored-by: parity-processbot <>
62 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
try_statehook in elections and EPM pallets and uses it in the tests. An improvement to this PR would be to work on paritytech/polkadot-sdk#210 to automatically include calling thetry_statehook in all tests.Related to paritytech/polkadot-sdk#239
Replaces #13718