This repository was archived by the owner on Nov 15, 2023. It is now read-only.
fix(in_mem): fix the clone logic#14038
Merged
bkchr merged 1 commit intoparitytech:masterfrom Apr 29, 2023
Merged
Conversation
cheme
approved these changes
Apr 28, 2023
Contributor
cheme
left a comment
cheme
left a comment
There was a problem hiding this comment.
LGTM.
From what I read (substrate only), this clone is not really use, but seems important to fix it (can be a footgun).
bkchr
approved these changes
Apr 29, 2023
bkchr
added
B0-silent
gpestana
pushed a commit
that referenced
this pull request
May 4, 2023
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
clonelogic is wrong. Should cloneArcrather than clone innerBlockchainStorage