This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Remove the Copy bound on CollectionId in the uniques pallet#14111
Merged
paritytech-processbot[bot] merged 2 commits intoparitytech:masterfrom May 10, 2023
Merged
Remove the Copy bound on CollectionId in the uniques pallet#14111paritytech-processbot[bot] merged 2 commits intoparitytech:masterfrom
Copy bound on CollectionId in the uniques pallet#14111paritytech-processbot[bot] merged 2 commits intoparitytech:masterfrom
Conversation
koute
added
A0-please_review
kianenigma
approved these changes
May 10, 2023
ggwpez
approved these changes
May 10, 2023
Member
ggwpez
left a comment
ggwpez
left a comment
There was a problem hiding this comment.
ItemId has the same thing going on. Not sure if that will annoy you later on as well.
Contributor
Author
Yeah, I don't know yet. (: I'll be doing this as I go through the compile errors that I encounter, and if I do I'll make another PR. (It's good to keep these PRs small anyway.) |
Contributor
Author
|
bot merge |
niklasad1
pushed a commit
that referenced
this pull request
May 17, 2023
* Remove the `Copy` bound on `CollectionId` in the uniques pallet * Also add `clone`s in benchmarks
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…tytech#14111) * Remove the `Copy` bound on `CollectionId` in the uniques pallet * Also add `clone`s in benchmarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relaxes the requirement that the
CollectionIdin the uniques pallet must beCopy.Motivation
I'm planning to make
AssetId/MultiLocationtypes inpolkadotnon-Copy(to reduce the size of those types by almost ~90%), and there's at least one crate inpolkadotwhich uses those types as aCollectionId.