This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Remove #[pallet::generate_storage_info] from docs#14116
Merged
paritytech-processbot[bot] merged 2 commits intomasterfrom May 10, 2023
Merged
Remove #[pallet::generate_storage_info] from docs#14116paritytech-processbot[bot] merged 2 commits intomasterfrom
#[pallet::generate_storage_info] from docs#14116paritytech-processbot[bot] merged 2 commits intomasterfrom
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A0-please_review
gpestana
approved these changes
May 10, 2023
Contributor
|
Wait no, it was valid when we didn't MEL bound our storage types, and can't be used in the old |
Member
Author
Ah yes, could be. But it also works in the old syntax substrate/frame/support/procedural/src/lib.rs Line 294 in 2a148e3
Yes, otherwise |
KiChjang
approved these changes
May 10, 2023
Member
Author
|
bot merge |
niklasad1
pushed a commit
that referenced
this pull request
May 17, 2023
* Fix docs Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add UI test Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Fix docs Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add UI test Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14089
#[pallet::generate_storage_info]is not valid, and was probably added to the docs in error.It is only valid in the old
decl_*pallet syntax.