Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

remove sp-serializer which is not useful#14134

Merged
paritytech-processbot[bot] merged 4 commits intoparitytech:masterfrom
yjhmelody:remove-sp-serializer
May 14, 2023
Merged

remove sp-serializer which is not useful#14134
paritytech-processbot[bot] merged 4 commits intoparitytech:masterfrom
yjhmelody:remove-sp-serializer

Conversation

@yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented May 12, 2023 •
edited by ggwpez
Loading

I think this is a legacy crate which is not very helpful anymore.

Cumulus Companion: paritytech/cumulus#2574

polkadot address: 15ouFh2SHpGbHtDPsJ6cXQfes9Cx1gEFnJJsJVqPGzBSTudr

bkchr
bkchr approved these changes May 12, 2023
View reviewed changes
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 12, 2023
@bkchr
Copy link
Member

bkchr commented May 12, 2023

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented May 12, 2023

Waiting for commit status.

@paritytech-processbot
Copy link

paritytech-processbot bot commented May 12, 2023

Merge cancelled due to error. Error: Statuses failed for 1223c61

@ggwpez
Copy link
Member

ggwpez commented May 13, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented May 13, 2023 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2831989 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 45-24041ef0-c984-44a6-bf5d-4edcb688255f to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 13, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2831989 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2831989/artifacts/download.

@ggwpez
Copy link
Member

ggwpez commented May 13, 2023

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented May 13, 2023

Waiting for commit status.

@paritytech-processbot
Copy link

paritytech-processbot bot commented May 13, 2023

Merge cancelled due to error. Error: Statuses failed for abdd1f7

@ggwpez
Copy link
Member

ggwpez commented May 13, 2023

It is used in cumulus. Could you do a companion please?

@yjhmelody
Copy link
Contributor Author

yjhmelody commented May 14, 2023 •
edited
Loading

@ggwpez ok.

Cumulus Companion PR: paritytech/cumulus#2574

@ggwpez
Copy link
Member

ggwpez commented May 14, 2023

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented May 14, 2023

Waiting for commit status.

@paritytech-processbot
Copy link

paritytech-processbot bot commented May 14, 2023

Merge cancelled due to error. Error: Statuses failed for abdd1f7

@ggwpez ggwpez mentioned this pull request May 14, 2023
Merged
@ggwpez
Copy link
Member

ggwpez commented May 14, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 1f9e3aa into paritytech:master May 14, 2023
@yjhmelody yjhmelody deleted the remove-sp-serializer branch May 15, 2023 03:04
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@yjhmelody @bkchr @nathanwhit
remove sp-serializer which is not useful (paritytech#14134)
b98c040 
* remove `sp-serializer` which is not useful

* Update primitives/core/Cargo.toml

* fix cargo.toml

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

5 more reviewers

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@bkchr bkchr bkchr approved these changes

@mrcnski mrcnski mrcnski approved these changes

@davxy davxy davxy approved these changes

@ggwpez ggwpez ggwpez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yjhmelody @bkchr @ggwpez @michalkucharczyk @mrcnski @davxy