This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Postpone public key creation in the test GenesisStorageBuilder#14142
Merged
Postpone public key creation in the test GenesisStorageBuilder#14142
Conversation
davxy
added
A0-please_review
michalkucharczyk
approved these changes
May 15, 2023
skunert
approved these changes
May 15, 2023
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…ytech#14142) * Postpone public key creation from account id in the test genesis storage builder * Store raw sr25519 in substrate test pallet * Nitpick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lazy creation of public keys from AccountId in the
GenesisStorageBuilder::build()method.Reason: the new strategy better fits when we require to create keys using a different scheme.
Previous approach assumes that all the runtime pallets will require the same scheme (sr25519) but this is not always the case (sassafras uses bandersnatch vrf keys or grandpa).
Postponing the creation of the keys allows to maintain only the account ids list in the builder and then create all the key types we require (currently only sr25519) when we require them
Other trivial tweaks:
substrate-test-pallet'sAuthoritiesstorage is used to store other protocols keys that doesn't instance the pallet within the test runtime (e.g. aura). Thus, is more appropriate to store a raw sr25519 key instead of the babe'sAuthorityIdnewtype.GenesisStorageBuilder::build_storage()tobuild(inline with typical name used by builder pattern)