Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Actually respect locks of zero#14144

Merged
paritytech-processbot[bot] merged 6 commits intomasterfrom
gav-fix-currency
May 23, 2023
Merged

Actually respect locks of zero#14144
paritytech-processbot[bot] merged 6 commits intomasterfrom
gav-fix-currency

Conversation

@gavofyork
Copy link
Member

@gavofyork gavofyork commented May 15, 2023 •
edited
Loading

When using set_lock to lock zero funds, it should not be a no-op (unlike extend_lock, in which it is).

@gavofyork gavofyork requested a review from a team May 15, 2023 12:10
@gavofyork gavofyork added A0-please_review Pull request needs code review. C3-medium PR touches the given topic and has a medium impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited B1-note_worthy Changes should be noted in the release notes labels May 15, 2023
@gavofyork gavofyork changed the title Actually thaw when locking zero Actually respect locks of zero May 15, 2023
@gavofyork gavofyork added the T1-runtime This PR/Issue is related to the topic “runtime”. label May 15, 2023
@vstam1 vstam1 mentioned this pull request May 15, 2023
Closed
@KiChjang
Copy link
Contributor

KiChjang commented May 15, 2023

What happens then when set_lock has a 0 amount? Does it function like remove_lock?

@gavofyork
Copy link
Member Author

gavofyork commented May 15, 2023

What happens then when set_lock has a 0 amount? Does it function like remove_lock?

Any previous lock should no longer constrain the balance liquidity, similar to if remove_lock is called. However, it is not specified whether any storage on chain is reclaimed, as it is with remove_lock. In the fungible API, set_freeze(0) is explicitly defined as being equivalent to thaw().

@gavofyork
Copy link
Member Author

gavofyork commented May 17, 2023

bot rebase

@paritytech-processbot
Copy link

paritytech-processbot bot commented May 17, 2023

Rebased

@gavofyork
Copy link
Member Author

gavofyork commented May 23, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit bc3ce83 into master May 23, 2023
@paritytech-processbot paritytech-processbot bot deleted the gav-fix-currency branch May 23, 2023 08:47
@xlc
Copy link
Contributor

xlc commented May 23, 2023

someone needs to write some tests for this

@liamaharon liamaharon mentioned this pull request May 26, 2023
Closed
gpestana pushed a commit that referenced this pull request May 27, 2023
@gavofyork @gpestana
Actually respect locks of zero (#14144)
dc154c0 
* Actually thaw when locking zero.

* Fixes

* Just remove the lock if semantically viable

---------

Co-authored-by: parity-processbot <>
@louismerlin louismerlin removed the D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited label Jun 1, 2023
@louismerlin louismerlin added the D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited label Jun 1, 2023
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
@jasl jasl mentioned this pull request Jun 30, 2023
Merged
@Agusrodri Agusrodri mentioned this pull request Jul 4, 2023
Merged
1 task
Ank4n pushed a commit that referenced this pull request Jul 8, 2023
@gavofyork @Ank4n
Actually respect locks of zero (#14144)
e07bf45 
* Actually thaw when locking zero.

* Fixes

* Just remove the lock if semantically viable

---------

Co-authored-by: parity-processbot <>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@gavofyork @nathanwhit
Actually respect locks of zero (paritytech#14144)
4abe643 
* Actually thaw when locking zero.

* Fixes

* Just remove the lock if semantically viable

---------

Co-authored-by: parity-processbot <>
@dmitrylavrenov dmitrylavrenov mentioned this pull request Oct 29, 2024
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

5 more reviewers

@sam0x17 sam0x17 sam0x17 approved these changes

@KiChjang KiChjang KiChjang approved these changes

@kianenigma kianenigma kianenigma approved these changes

@bkchr bkchr bkchr approved these changes

@vstam1 vstam1 vstam1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C3-medium PR touches the given topic and has a medium impact on builders. D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited T1-runtime This PR/Issue is related to the topic “runtime”.

Projects

Runtime / FRAME
Status: Done
Security Audit (PRs) - SRLabs
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gavofyork @KiChjang @xlc @sam0x17 @kianenigma @bkchr @vstam1 @louismerlin