This repository was archived by the owner on Nov 15, 2023. It is now read-only.
remote-externalities: retry for get_keys#14167
Merged
paritytech-processbot[bot] merged 4 commits intomasterfrom May 19, 2023
Merged
remote-externalities: retry for get_keys#14167paritytech-processbot[bot] merged 4 commits intomasterfrom
paritytech-processbot[bot] merged 4 commits intomasterfrom
Conversation
liamaharon
added
A0-please_review
ggwpez
approved these changes
May 17, 2023
ggwpez
approved these changes
May 17, 2023
niklasad1
approved these changes
May 18, 2023
Contributor
niklasad1
left a comment
niklasad1
left a comment
There was a problem hiding this comment.
Fine for now, it just that hyper client has its background task if something goes wrong there this won't make any progress with your fix.
Ideally, the client should "reconnect" in some scenarios but as that is involved to fix.
sam0x17
approved these changes
May 18, 2023
…mote-ext-get-keys-retry
Contributor
Author
|
bot merge |
gpestana
pushed a commit
that referenced
this pull request
May 27, 2023
* retry get keys request * remove redundant clone * remove redundant at
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* retry get keys request * remove redundant clone * remove redundant at
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14129
Retries get key requests once every 5s up to 12 times (60s total).
Logs demonstrating behavior when I took my node down while keys were being scraped and booted it back up ~30 seconds later:
I don't believe we'll need this retry logic for the other requests that're not made in rapid succession, but we should keep an eye on it.