This repository was archived by the owner on Nov 15, 2023. It is now read-only.
wasm: Update from v6.0.2 to v8.0.1#14178
Merged
paritytech-processbot[bot] merged 3 commits intomasterfrom May 24, 2023
Merged
Conversation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
lexnv
added
A0-please_review
KiChjang
approved these changes
May 19, 2023
jsdw
approved these changes
May 19, 2023
Contributor
|
Please wait with merging this; I need to run a few benchmarks first to make sure the performance has not regressed. |
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
koute
approved these changes
May 22, 2023
Contributor
koute
left a comment
koute
left a comment
There was a problem hiding this comment.
Performance seems fine; LGTM!
This was referenced May 22, 2023
Contributor
Author
|
bot merge |
gpestana
pushed a commit
that referenced
this pull request
May 27, 2023
* wasm: Update from v6.0.2 to v8.0.1 Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Fix rustix version Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
15 tasks
Ank4n
pushed a commit
that referenced
this pull request
Jul 8, 2023
* wasm: Update from v6.0.2 to v8.0.1 Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Fix rustix version Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* wasm: Update from v6.0.2 to v8.0.1 Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Fix rustix version Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
wasmtimefrom v6.0.2 to v8.0.1.Having an older version causes build errors in subxt with smoldot.
Subxt relies on sp-runtime which was bringing wasmtime v6.0.2, while smoldot has wasmtime v8.0.1.
This change reflects in
sp-runtime,sp-core,sp-keyringprimarily.paritytech/subxt#965
polkadot companion: paritytech/polkadot#7268
cumulus companion: paritytech/cumulus#2623
// @paritytech/subxt-team