`test-runtime`: `GenesisBuilder` runtime API impl + tests by michalkucharczyk · Pull Request #14310 · paritytech/substrate

michalkucharczyk · 2023-06-06T18:40:33Z

This PR provides implementation of GenesisBuilder API (proposed here: #14131) for substrate-test-runtime, can be considered as reference imiplementation for other runtimes.

The GenesisBuilder implementation is gated by gensis-builder feature.

A small crate (sc-genesis-builder) was added. Its purpose is to provide the implementation of GenesisBuilder API in the form of reusable helper.

Tested scenarios:

default GenesisConfig to JSON blob,
deserialization of GenesisConfig from custom JSON, and storing its keys into the Storage (genesis storage creation).
creation of genesis storage using full JSON definition (not allowing for any defaults),
creation of genesis storage using partial JSON definition (as discussed here) on top of default values,
checking if invalid/renamed keys in JSON files provides informative errors,

Step towards: paritytech/polkadot-sdk#25

This PR provides implementation of `GenesisBuilder` API for `substrate-test-runtime`, can be considered as reference imiplementation for other runtimes. The `GenesisBuilder` implementation is gated by `gensis-config` feature. Tested scenarios: - default `GenesisConfig` to JSON blob, - deserialization of `GenesisConfig` from custom JSON, and storing its keys into the Storage (genesis storage creation). - creation of genesis storage using partial JSON definition, - checking if invalid/renamed JSON files causes the runtime to panic,

test-utils/runtime/src/lib.rs

test-utils/runtime/src/test_json/readme.md

test-utils/runtime/src/test_json/default_genesis_config.json

client/genesis-builder/src/lib.rs

test-utils/runtime/Cargo.toml

test-utils/runtime/src/genesismap.rs

test-utils/runtime/src/lib.rs

Co-authored-by: Davide Galassi <davxy@datawok.net>

skunert

Looks Good!
I am also not sure if the genesis-builder feature is useful, but leave it up to you.

frame/support/src/genesis_builder_helper.rs

michalkucharczyk · 2023-07-21T11:18:53Z

bot rebase

…-implemented-for-test-runtime

paritytech-processbot · 2023-07-21T11:19:00Z

Rebased

test-utils/runtime/src/lib.rs

kianenigma

LGTM other than a grumble about naming which I hope to see fixed before this is stabilized.

michalkucharczyk · 2023-07-22T05:45:20Z

bot fmt

command-bot · 2023-07-22T05:45:25Z

@michalkucharczyk https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3240071 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-3afdb878-f7a1-4447-9c6d-5268e6ffeec9 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-07-22T05:49:07Z

@michalkucharczyk Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3240071 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3240071/artifacts/download.

michalkucharczyk · 2023-07-24T14:07:46Z

LGTM other than a grumble about naming which I hope to see fixed before this is stabilized.

Created issue for cleaning up naming: paritytech/polkadot-sdk#150

…-implemented-for-test-runtime

michalkucharczyk · 2023-07-24T16:12:45Z

bot merge

michalkucharczyk added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 6, 2023

missing file added

b2bb68f

michalkucharczyk requested a review from a team June 6, 2023 18:45

michalkucharczyk mentioned this pull request Jun 6, 2023

GenesisBuilder runtime API #14131

Merged

michalkucharczyk commented Jun 6, 2023

View reviewed changes

test-utils/runtime/src/lib.rs Outdated Show resolved Hide resolved

michalkucharczyk commented Jun 6, 2023

View reviewed changes

test-utils/runtime/src/lib.rs Outdated Show resolved Hide resolved

michalkucharczyk added 7 commits June 7, 2023 10:42

client: GenesisBuilder helper added

c4e3251

feature renamed: genesis-config -> genesis-builder

1b86fc2

Update Cargo.toml

f317d82

Update Cargo.toml

e720dc1

Update Cargo.toml

c89ba8c

Update Cargo.toml

b320c13

redundant function removed

961a09c

michalkucharczyk changed the title ~~test-runtime: GenesisBuilder runtime API impl + tests~~ test-runtime: GenesisBuilder runtime API impl + tests Jun 9, 2023

michalkucharczyk added 7 commits June 12, 2023 12:24

genesis builder helper: introduced RuntimeGenesisBuild

1ee307f

test-runtime: get rid of unused T

1fd7662

redundant bound removed

137c08a

helper: use GenesisBuild again

856dc3b

tests adjusted for on_genesis

ad29d4c

test-runtime: support for BuildGenesisConfig

1e342cf

helper: BuildGenesisConfig support

c5cdf9f

davxy reviewed Jun 19, 2023

View reviewed changes

davxy requested a review from a team June 19, 2023 18:04

michalkucharczyk and others added 4 commits June 19, 2023 23:10

Update client/genesis-builder/src/lib.rs

5797c9c

Co-authored-by: Davide Galassi <davxy@datawok.net>

Update test-utils/runtime/src/test_json/readme.md

08c7be3

Co-authored-by: Davide Galassi <davxy@datawok.net>

Update test-utils/runtime/src/test_json/readme.md

26f7bb1

Co-authored-by: Davide Galassi <davxy@datawok.net>

Update test-utils/runtime/src/genesismap.rs

260448e

Co-authored-by: Davide Galassi <davxy@datawok.net>

Cargo.lock + test-utils/runtime/Cargo.toml updated

807546e

michalkucharczyk changed the title ~~test-runtime: GenesisBuilder runtime API impl + tests~~ test-runtime: GenesisBuilder runtime API impl + tests Jul 12, 2023

michalkucharczyk added 3 commits July 12, 2023 15:39

doc fixed

9192046

client/rpc: test fixed (new rt api)

3987695

client/rpc-spec-v2: test fix

a6ee7b1

michalkucharczyk requested a review from a team July 12, 2023 15:01

michalkucharczyk mentioned this pull request Jul 12, 2023

chain-spec: support for json config/patch (and GenesisBuilder API) #14562

Open

skunert approved these changes Jul 18, 2023

View reviewed changes

frame/support/src/genesis_builder_helper.rs Outdated Show resolved Hide resolved

doc fix

59d2d29

michalkucharczyk mentioned this pull request Jul 21, 2023

GenesisConfig in a native runtime free world paritytech/polkadot-sdk#25

Closed

michalkucharczyk added 2 commits July 21, 2023 11:49

test-runtime: disable-genesis-builder feature

3b34d24

fix

96069a0

Merge remote-tracking branch 'origin/master' into mku-genesis-builder…

5899dfa

…-implemented-for-test-runtime

fix

33f0b4d

kianenigma reviewed Jul 21, 2023

View reviewed changes

test-utils/runtime/src/lib.rs Show resolved Hide resolved

kianenigma approved these changes Jul 21, 2023

View reviewed changes

".git/.scripts/commands/fmt/fmt.sh"

0ebabe1

sam0x17 approved these changes Jul 24, 2023

View reviewed changes

michalkucharczyk mentioned this pull request Jul 24, 2023

Adjust GenesisBuilder naming paritytech/polkadot-sdk#150

Closed

michalkucharczyk added 2 commits July 24, 2023 17:22

test-runtime: rerun added to build script

e5094e8

Merge remote-tracking branch 'origin/master' into mku-genesis-builder…

f92943e

…-implemented-for-test-runtime

paritytech-processbot bot merged commit 7a762e4 into master Jul 24, 2023

paritytech-processbot bot deleted the mku-genesis-builder-implemented-for-test-runtime branch July 24, 2023 16:12

Conversation

michalkucharczyk commented Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skunert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

michalkucharczyk commented Jul 21, 2023

Uh oh!

paritytech-processbot bot commented Jul 21, 2023

Uh oh!

Uh oh!

kianenigma left a comment

Choose a reason for hiding this comment

Uh oh!

michalkucharczyk commented Jul 22, 2023

Uh oh!

command-bot bot commented Jul 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jul 22, 2023

Uh oh!

michalkucharczyk commented Jul 24, 2023

Uh oh!

michalkucharczyk commented Jul 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

michalkucharczyk commented Jun 6, 2023 •

edited

Loading

command-bot bot commented Jul 22, 2023 •

edited

Loading