contracts: Refactor instantiate with code by pgherveou · Pull Request #14503 · paritytech/substrate

pgherveou · 2023-07-03T18:31:18Z

Refactor instantiate_with_code, so that it always store the code first and then instantiate the contract.
This simplify the logic a bit and ensure that CodeInfo is always in storage before the code is instantiated.

Fixes #14494

pgherveou · 2023-07-03T21:42:02Z

bot bench $ pallet dev pallet_contracts

command-bot · 2023-07-03T21:42:07Z

@pgherveou https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3115214 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 17-bb80dee3-9271-47e4-a0fe-ef82c4127ae8 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-07-03T23:18:55Z

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3115214 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3115214/artifacts/download.

pgherveou · 2023-07-04T05:53:57Z

bot rebase

paritytech-processbot · 2023-07-04T05:54:03Z

Rebased

athei · 2023-07-04T08:46:42Z

Does it fix #14494?

pgherveou · 2023-07-04T09:23:57Z

Does it fix #14494?

ha nice missed that issue, it should yes, I am refactoring this other PR (currently broken) #14079 that depends on it, let me go through it to verify that it indeed improve things

pgherveou · 2023-07-05T11:27:35Z

bot bench $ pallet dev pallet_contracts

command-bot · 2023-07-05T11:27:40Z

@pgherveou https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3130950 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-5c51622d-76d2-4f1a-b25a-334bc22758e3 to cancel this command or bot cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2023-07-05T13:04:59Z

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3130950 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3130950/artifacts/download.

pgherveou · 2023-07-05T13:07:01Z

https://weights.tasty.limo/compare?unit=weight&ignore_errors=true&threshold=10&method=asymptotic&repo=substrate&old=pg/simplify_instantiate_with_code&new=master&path_pattern=frame/**/src/weights.rs

frame/contracts/src/lib.rs

frame/contracts/src/wasm/mod.rs

frame/contracts/src/lib.rs

frame/contracts/src/wasm/mod.rs

frame/contracts/src/lib.rs

Co-authored-by: Sasha Gryaznov <hi@agryaznov.com>

pgherveou · 2023-07-06T12:01:55Z

pgherveou · 2023-07-06T12:10:43Z

bot bench $ pallet dev pallet_contracts

command-bot · 2023-07-06T12:10:48Z

@pgherveou https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3139251 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-a07cfa94-6594-4fbb-be71-0d2f39934036 to cancel this command or bot cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2023-07-06T13:49:25Z

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3139251 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3139251/artifacts/download.

pgherveou · 2023-07-07T10:07:48Z

The +155% performance decrease for seal_ecdsa is related to this PR that revert a recent attempt to start using a C lib instead of k256 see #14499

pgherveou · 2023-07-07T13:46:08Z

bot merge

* wip * fixes * rm comment * join fns * clippy * Fix limits * reduce diff * fix * fix * fix typo * refactor store to use self * refactor run to take self by value * pass tests * rm comment * fixes * fix typo * rm * fix fmt * clippy * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts * Update frame/contracts/src/lib.rs Co-authored-by: Sasha Gryaznov <hi@agryaznov.com> * Update frame/contracts/src/wasm/mod.rs Co-authored-by: Sasha Gryaznov <hi@agryaznov.com> * Update frame/contracts/src/wasm/mod.rs Co-authored-by: Sasha Gryaznov <hi@agryaznov.com> * PR review, rm duplicate increment_refcount * PR review * Update frame/contracts/src/wasm/prepare.rs Co-authored-by: Sasha Gryaznov <hi@agryaznov.com> * Add test for failing storage_deposit * fix lint * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts --------- Co-authored-by: command-bot <> Co-authored-by: Sasha Gryaznov <hi@agryaznov.com>

pgherveou changed the title ~~pg/simplify instantiate with code~~ contracts: instantiate with code Jul 3, 2023

pgherveou changed the title ~~contracts: instantiate with code~~ contracts: Refactor instantiate with code Jul 3, 2023

pgherveou force-pushed the pg/simplify_instantiate_with_code branch from d8f2b02 to 48e5a34 Compare July 3, 2023 19:22

pgherveou marked this pull request as ready for review July 3, 2023 21:38

pgherveou requested a review from athei as a code owner July 3, 2023 21:38

pgherveou requested a review from a team July 3, 2023 21:38

pgherveou force-pushed the pg/simplify_instantiate_with_code branch from 703115a to 6a2aa17 Compare July 4, 2023 05:22

pgherveou added 12 commits July 5, 2023 11:33

wip

304d84b

fixes

4e80ea6

rm comment

dc744af

join fns

5f9a226

clippy

b6def6d

Fix limits

76c43c2

reduce diff

83e5f37

fix

e3c51ec

fix

8c15372

fix typo

c97708b

refactor store to use self

0180777

refactor run to take self by value

89accc8

command-bot added 2 commits July 5, 2023 11:30

Merge branch 'master' of https://github.com/paritytech/substrate into…

672e92e

… HEAD

".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts

68ba74d

agryaznov reviewed Jul 5, 2023

View reviewed changes

pgherveou and others added 6 commits July 6, 2023 09:00

Update frame/contracts/src/lib.rs

e8ceb0d

Co-authored-by: Sasha Gryaznov <hi@agryaznov.com>

Update frame/contracts/src/wasm/mod.rs

9eb7833

Co-authored-by: Sasha Gryaznov <hi@agryaznov.com>

Update frame/contracts/src/wasm/mod.rs

96e3dcf

Co-authored-by: Sasha Gryaznov <hi@agryaznov.com>

PR review, rm duplicate increment_refcount

a9df0cc

PR review

b291902

Update frame/contracts/src/wasm/prepare.rs

bc2057d

Co-authored-by: Sasha Gryaznov <hi@agryaznov.com>

pgherveou added 2 commits July 6, 2023 14:10

Add test for failing storage_deposit

bbf2c5b

fix lint

dff4758

command-bot added 2 commits July 6, 2023 12:13

Merge branch 'master' of https://github.com/paritytech/substrate into…

e1b73af

… HEAD

".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts

5837c09

agryaznov approved these changes Jul 6, 2023

View reviewed changes

pgherveou mentioned this pull request Jul 7, 2023

Contracts Add deposit for dependencies #14079

Merged

athei requested a review from juangirini July 7, 2023 13:15

athei approved these changes Jul 7, 2023

View reviewed changes

paritytech-processbot bot merged commit 7aacdf1 into master Jul 7, 2023

paritytech-processbot bot deleted the pg/simplify_instantiate_with_code branch July 7, 2023 13:46

Conversation

pgherveou commented Jul 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pgherveou commented Jul 3, 2023

Uh oh!

command-bot bot commented Jul 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jul 3, 2023

Uh oh!

pgherveou commented Jul 4, 2023

Uh oh!

paritytech-processbot bot commented Jul 4, 2023

Uh oh!

athei commented Jul 4, 2023

Uh oh!

pgherveou commented Jul 4, 2023

Uh oh!

pgherveou commented Jul 5, 2023

Uh oh!

command-bot bot commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jul 5, 2023

Uh oh!

pgherveou commented Jul 5, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pgherveou commented Jul 6, 2023

Uh oh!

pgherveou commented Jul 6, 2023

Uh oh!

command-bot bot commented Jul 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jul 6, 2023

Uh oh!

pgherveou commented Jul 7, 2023

Uh oh!

pgherveou commented Jul 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pgherveou commented Jul 3, 2023 •

edited

Loading

command-bot bot commented Jul 3, 2023 •

edited

Loading

command-bot bot commented Jul 5, 2023 •

edited

Loading

command-bot bot commented Jul 6, 2023 •

edited

Loading