This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Pallets: Asset Rate - Rename AssetId to AssetKind, Introduce AssetKindFactory Trait#14514
Merged
paritytech-processbot[bot] merged 10 commits intomasterfrom Jul 26, 2023
Merged
Conversation
muharem
added
A0-please_review
muharem
added
the
F3-breaks_API
Contributor
Author
|
rename originally proposed for the treasury pallet the same reason #13607 (comment) |
joepetrowski
approved these changes
Jul 20, 2023
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
…benchmarks-rename
ggwpez
approved these changes
Jul 26, 2023
ggwpez
reviewed
Jul 26, 2023
Contributor
Author
|
bot merge |
paritytech-processbot
bot
deleted the
muharem-asset-rate-benchmarks-rename
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Asset Rate Pallet, the
AssetIdtype parameter has been renamed toAssetKind. Alongside this change, theAssetKindFactorytrait has been introduced specifically for benchmarks.For Polkadot and Kusama, the
AssetKindwill be represented as a type consisting of(xcm::MultiLocation, xcm::AssetId). This renaming is done to avoid naming collisions. And since it is not suitable to implementFrom<u32>for such a type, we introduce theAssetKindFactorytrait as a solution.