This repository was archived by the owner on Nov 15, 2023. It is now read-only.
improve pallet hooks docs#14578
Merged
paritytech-processbot[bot] merged 15 commits intomasterfrom Jul 17, 2023
Merged
Conversation
kianenigma
added
A0-please_review
This was referenced Jul 15, 2023
sam0x17
approved these changes
Jul 15, 2023
Contributor
sam0x17
left a comment
sam0x17
left a comment
There was a problem hiding this comment.
a few nits, one that was substantive
Co-authored-by: Sam Johnson <sam@durosoft.com>
Co-authored-by: Sam Johnson <sam@durosoft.com>
Co-authored-by: Sam Johnson <sam@durosoft.com>
Contributor
Author
|
bot fmt |
|
@kianenigma https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3197965 was started for your command Comment |
Contributor
Author
|
bot rebase |
|
Rebased |
|
@kianenigma Command |
gui1117
reviewed
Jul 17, 2023
…ate into kiz-improve-hooks-docs
Co-authored-by: Juan <juangirini@gmail.com>
…ate into kiz-improve-hooks-docs
gpestana
approved these changes
Jul 17, 2023
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* improve pallet hooks docs * Update frame/support/src/traits/hooks.rs Co-authored-by: Sam Johnson <sam@durosoft.com> * Update frame/support/src/traits/hooks.rs Co-authored-by: Sam Johnson <sam@durosoft.com> * Update frame/support/src/traits/hooks.rs Co-authored-by: Sam Johnson <sam@durosoft.com> * fix mastekn removal * Apply suggestions from code review Co-authored-by: Juan <juangirini@gmail.com> * add diagram * fix all links * fix diagram * improve diagram with some notes * update --------- Co-authored-by: Sam Johnson <sam@durosoft.com> Co-authored-by: parity-processbot <> Co-authored-by: Juan <juangirini@gmail.com>
Ank4n
pushed a commit
that referenced
this pull request
Jul 22, 2023
* improve pallet hooks docs * Update frame/support/src/traits/hooks.rs Co-authored-by: Sam Johnson <sam@durosoft.com> * Update frame/support/src/traits/hooks.rs Co-authored-by: Sam Johnson <sam@durosoft.com> * Update frame/support/src/traits/hooks.rs Co-authored-by: Sam Johnson <sam@durosoft.com> * fix mastekn removal * Apply suggestions from code review Co-authored-by: Juan <juangirini@gmail.com> * add diagram * fix all links * fix diagram * improve diagram with some notes * update --------- Co-authored-by: Sam Johnson <sam@durosoft.com> Co-authored-by: parity-processbot <> Co-authored-by: Juan <juangirini@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subset of #14279, making it ready earlier for PBA.
Companion to #13987
@liamaharon possibly you want to add more about migrations?