Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

[fix lint warnings: Uniques pallet] fix clippy::missing_errors_doc lint warnings#14588

Merged
paritytech-processbot[bot] merged 7 commits intomasterfrom
sl/nfts-pallet-docs-review
Aug 14, 2023
Merged

[fix lint warnings: Uniques pallet] fix clippy::missing_errors_doc lint warnings#14588
paritytech-processbot[bot] merged 7 commits intomasterfrom
sl/nfts-pallet-docs-review

Conversation

@sacha-l
Copy link
Contributor

@sacha-l sacha-l commented Jul 17, 2023

This PR fixes the 7 lint warnings emitted by the missing_errors_doc lint in the Uniques pallet by adding an # Errors section to the common helper functions.

This is part of an ongoing effort from the @paritytech/devrel team to improve developer experience.

@sacha-l sacha-l added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 17, 2023
@sacha-l sacha-l requested a review from aaronbassett July 17, 2023 14:38
@sacha-l sacha-l requested a review from jsidorenko as a code owner July 17, 2023 14:38
@sacha-l sacha-l requested a review from a team July 17, 2023 14:38
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the uniques pallet is even in use anymore? PS: @jsidorenko

@jsidorenko
Copy link
Contributor

jsidorenko commented Jul 17, 2023

Not sure if the uniques pallet is even in use anymore?

check your Decoded NFT ;) it was minted using the uniques pallet

@ggwpez
Copy link
Member

ggwpez commented Jul 17, 2023

check your Decoded NFT ;) it was minted using the uniques pallet

Lol okay 😆 I thought it was replaced by the NFTs pallet 🤷‍♂️

@sacha-l sacha-l added the I6-documentation Documentation needs fixing, improving or augmenting. label Jul 27, 2023
@sacha-l sacha-l requested a review from Ank4n July 27, 2023 12:45
@sacha-l
Copy link
Contributor Author

sacha-l commented Aug 14, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@sacha-l
Copy link
Contributor Author

sacha-l commented Aug 14, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@sacha-l
Copy link
Contributor Author

sacha-l commented Aug 14, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 837e481 into master Aug 14, 2023
@paritytech-processbot paritytech-processbot bot deleted the sl/nfts-pallet-docs-review branch August 14, 2023 15:34
Ank4n pushed a commit that referenced this pull request Aug 20, 2023
…nt warnings (#14588)

* Fix clippy::missing_errors_doc lint warnings

* update error docs

* cargo +nightly fmt

* add intra doc linking

* fmt

---------

Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit I6-documentation Documentation needs fixing, improving or augmenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants