Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Handle the AllowMultiAssetPools=false case in benchmarks#14590

Merged
paritytech-processbot[bot] merged 3 commits intomasterfrom
js/fix-asset-conversion-benchmarks
Jul 18, 2023
Merged

Handle the AllowMultiAssetPools=false case in benchmarks#14590
paritytech-processbot[bot] merged 3 commits intomasterfrom
js/fix-asset-conversion-benchmarks

Conversation

@jsidorenko
Copy link
Contributor

@jsidorenko jsidorenko commented Jul 17, 2023

@jsidorenko jsidorenko added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 17, 2023
@jsidorenko jsidorenko requested review from a team and bkontur July 17, 2023 15:18
@bkontur
Copy link
Contributor

bkontur commented Jul 17, 2023

bot bench $ pallet dev pallet_asset_conversion

@command-bot
Copy link

command-bot bot commented Jul 17, 2023 •
edited
Loading

@bkontur https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3203926 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_asset_conversion. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 11-3c005aa6-70f6-4b6d-99d3-c24c365fddab to cancel this command or bot cancel to cancel all commands in this pull request.

@jsidorenko jsidorenko requested a review from joepetrowski July 17, 2023 15:25
@command-bot
Copy link

command-bot bot commented Jul 17, 2023

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_asset_conversion has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3203926 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3203926/artifacts/download.

@bkontur
Copy link
Contributor

bkontur commented Jul 18, 2023

bot rebase

@paritytech-processbot
Copy link

paritytech-processbot bot commented Jul 18, 2023

Rebased

@jsidorenko
Copy link
Contributor Author

jsidorenko commented Jul 18, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 89b352a into master Jul 18, 2023
@paritytech-processbot paritytech-processbot bot deleted the js/fix-asset-conversion-benchmarks branch July 18, 2023 09:38
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@jsidorenko @nathanwhit
Handle the AllowMultiAssetPools=false case in benchmarks (paritytech#…
e7dc030 
…14590)

* Handle the AllowMultiAssetPools=false case in benchmarks

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_asset_conversion

---------

Co-authored-by: command-bot <>
Ank4n pushed a commit that referenced this pull request Jul 22, 2023
@jsidorenko @Ank4n
Handle the AllowMultiAssetPools=false case in benchmarks (#14590)
8de3201 
* Handle the AllowMultiAssetPools=false case in benchmarks

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_asset_conversion

---------

Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@bkontur bkontur bkontur approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[asset-conversion] Fix benchmarks swap_exact_tokens_for_tokens / swap_tokens_for_exact_tokens

3 participants

@jsidorenko @bkontur @joepetrowski